Fixes Fortran compilation on Windows #3839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtnfld
added
Merge - To 1.14
Priority - 1. High 🔼
brtnfld
requested review from
derobins,
epourmal,
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
|
Need to resolve subfiling DLLs when parallel is enabled. |
hyoklee
approved these changes
Nov 9, 2023
byrnHDF
requested changes
Nov 9, 2023
| if(MSVC) | ||
| set(DLLDEF ${HDF5_F90_SRC_BINARY_DIR}/hdf5_fortrandll.def) | ||
| endif() | ||
| add_library (${HDF5_F90_LIBSH_TARGET} SHARED ${DLLDEF} ${f90_F_SOURCES_SHARED}) |
There was a problem hiding this comment.
This relies on "DLLDEF" not being defined for non-msvc. I would prefer that we use an if/else here and in the other file. The other question and maybe why the other form did not work - should we check for it being on windows "if (WIN32) " instead of "if (MSVC)" - because those are not the same thing. (Another choice is "if (WINDOWS)")
| # set_property(TARGET ${HDF5_F90_LIBSH_TARGET} APPEND PROPERTY LINK_FLAGS "$<$<STREQUAL:x${CMAKE_Fortran_SIMULATE_ID},xMSVC>:${WIN_LINK_FLAGS}>") | ||
| # set_property(TARGET ${HDF5_F90_LIBSH_TARGET} APPEND PROPERTY LINK_FLAGS "$<$<STREQUAL:x${CMAKE_Fortran_SIMULATE_ID},xMSVC>:-DLL>") | ||
| # set_property(TARGET ${HDF5_F90_LIBSH_TARGET} APPEND PROPERTY LINK_FLAGS "$<$<STREQUAL:x${CMAKE_Fortran_SIMULATE_ID},xMSVC>:-DEF:${HDF5_F90_SRC_BINARY_DIR}/hdf5_fortrandll.def>") | ||
| if(MSVC) |
There was a problem hiding this comment.
Maybe MSVC should be WIN32? OR maybe the commented out property commands might work now?
|
Replaced with PR #3836 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unresolved symbols with Fortran libraries on Windows with Intel OneAPI.