Test and document path handling of H5Lcreate_* API #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
Merge - To 1.14
Priority - 3. Low 🔽
mattjala
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
brtnfld
as code owners
byrnHDF
approved these changes
Nov 6, 2023
fortnern
reviewed
Nov 7, 2023
fortnern
reviewed
Nov 7, 2023
fortnern
reviewed
Nov 7, 2023
mattjala
force-pushed
the
soft_link_path_doc
branch
from
2623153 to
cd99373
Compare
mattjala
changed the title
mattjala
added
the
Component - Testing
mattjala
force-pushed
the
soft_link_path_doc
branch
from
53f531d to
2b534eb
Compare
|
Added tests in |
test/links.c
Outdated
| } | ||
|
|
||
| /*------------------------------------------------------------------------- | ||
| * Function: ext_link_path_handling |
There was a problem hiding this comment.
ud_link_path_handling
jhendersonHDF
approved these changes
Nov 10, 2023
fortnern
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs incorrectly say that
H5Lcreate_softcan't take a path as its link name, and don't mention absolute path handling in any of theH5Lcreate_*documentation.Fix #3827.