Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows cpack error in WiX package. #3750

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix windows cpack error in WiX package. #3750

merged 1 commit into from
Oct 24, 2023

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Oct 22, 2023

Packaging fails on Windows because of duplicate IDs. Doxygen install command used a generic name.

@byrnHDF byrnHDF added Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Documentation Doxygen, markdown, etc. Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Branch - 1.14 labels Oct 22, 2023
@byrnHDF byrnHDF self-assigned this Oct 22, 2023
@byrnHDF byrnHDF marked this pull request as draft October 22, 2023 19:11
@derobins derobins marked this pull request as ready for review October 24, 2023 16:19
@derobins derobins merged commit 1533df6 into HDFGroup:hdf5_1_14 Oct 24, 2023
40 checks passed
@byrnHDF byrnHDF deleted the hdf5_1_14-win-pack branch November 3, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derobins derobins derobins approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Documentation Doxygen, markdown, etc. Merge Use this label when a PR is for a downstream merge Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byrnHDF @derobins