Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test zlib with subfiling. #3692

Closed
wants to merge 1 commit into from
Closed

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Oct 17, 2023

minimal viable test

Copy link
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) It is important to create a new test function instead of modifying the behavior of an existing one.
(2) In your code, you have created a variable called "plist_id," but it is not being used, so compression is not performed. A thorough test should identify this issue.

@hyoklee
Copy link
Member Author

hyoklee commented Oct 17, 2023

(1) It is important to create a new test function instead of modifying the behavior of an existing one. (2) In your code, you have created a variable called "plist_id," but it is not being used, so compression is not performed. A thorough test should identify this issue.

@brtnfld , thanks for reviewing quickly!

What do you mean by plist_id is not being used. E.g., I thought the following uses plist_id:

VRFY((H5Pset_chunk(plist_id, 1, chunk_dims) >= 0), "H5Pset_chunk succeeded");

Please help me what I missed.

chunk_dims[0] = dset_dims[0] / 2;
VRFY((H5Pset_chunk(plist_id, 1, chunk_dims) >= 0), "H5Pset_chunk succeeded");
VRFY((H5Pset_deflate(plist_id, 9) >= 0), "H5Pset_deflate succeeded");
#endif
dset_id = H5Dcreate2(file_id, "DSET", SUBF_HDF5_TYPE, fspace_id, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT);
Copy link
Contributor

@brtnfld brtnfld Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be for chunked/compressed dataset,

dset_id = H5Dcreate2(file_id, "DSET", SUBF_HDF5_TYPE, fspace_id, H5P_DEFAULT, plist_id, H5P_DEFAULT);

@hyoklee hyoklee closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants