Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error in ID iteration for NULL object #3625

Closed
wants to merge 1 commit into from
Closed

Throw error in ID iteration for NULL object #3625

wants to merge 1 commit into from

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Oct 3, 2023

Fixes a segfault that would occur when using a non-native VOL with an H5Iiterate callback that doesn't check for NULL itself (for example, H5Z__check_unregister_dset_cb as used in H5Zunregister).

@mattjala
Throw error in ID iteration for NULL object
ffe48c4 
Fixes a segfault that would occur when using a non-native VOL
while using an H5Iiterate callback that doesn't check for NULL
itself (for example, H5Z__check_unregister_dset_cb as used
in H5Zunregister).
@mattjala mattjala added Merge - To 1.14 Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - C Library Core C library issues (usually in the src directory) Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub labels Oct 3, 2023
@mattjala mattjala marked this pull request as draft October 3, 2023 18:40
@mattjala
Copy link
Contributor Author

mattjala commented Oct 3, 2023

This ended up causing more problem for the VOL connectors than it solved - a lot of API calls use H5Iiterate in a way that doesn't depend on the provided object pointer. A different workaround for the problem this was trying to solve (using H5Zunregister with VOL connectors) is provided in #3629.

@mattjala mattjala closed this Oct 3, 2023
@mattjala mattjala deleted the id_iterate_null_fail branch September 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattjala