Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for selection I/O. #3528

Merged
merged 87 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
9779f18
Add more tests for selection I/O.
vchoi-hdfgroup Sep 11, 2023
16f6509
Committing clang-format changes
github-actions[bot] Sep 11, 2023
864b90e
Correction for CI test failure: remove debugging "ifdef OUT".
vchoi-hdfgroup Sep 11, 2023
55530fd
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 11, 2023
7b62d24
Committing clang-format changes
github-actions[bot] Sep 11, 2023
d1e7f52
Try to correct CI test error for windows.
vchoi-hdfgroup Sep 11, 2023
89551d9
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 11, 2023
b4d9fca
Print out data values that fail when comparing data.
vchoi-hdfgroup Sep 12, 2023
9a71218
Committing clang-format changes
github-actions[bot] Sep 12, 2023
660d1c3
Correct memset error.
vchoi-hdfgroup Sep 12, 2023
514ae8f
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 12, 2023
9cac20a
More corrections.
vchoi-hdfgroup Sep 12, 2023
60041d9
Committing clang-format changes
github-actions[bot] Sep 12, 2023
4fadd91
More changes in the routine for printing data values
vchoi-hdfgroup Sep 12, 2023
31dd35d
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 12, 2023
da3e7ae
Committing clang-format changes
github-actions[bot] Sep 12, 2023
83763d0
More debugging printfs.
vchoi-hdfgroup Sep 13, 2023
1df8f6c
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 13, 2023
4b12ee7
Committing clang-format changes
github-actions[bot] Sep 13, 2023
382f7b2
Correct CI test errors.
vchoi-hdfgroup Sep 13, 2023
6c785a5
Committing clang-format changes
github-actions[bot] Sep 13, 2023
88b3a73
More debugging changes
vchoi-hdfgroup Sep 13, 2023
8b8e1c1
More debuggging changes
vchoi-hdfgroup Sep 13, 2023
ac72341
Changes to test_select_dst_subset(): write/close/read dataset
vchoi-hdfgroup Sep 13, 2023
e87a93f
Turn off mwbuf.
vchoi-hdfgroup Sep 13, 2023
c374a38
Restore some changes to compare_stype4_data()
vchoi-hdfgroup Sep 13, 2023
a3ed0c5
Committing clang-format changes
github-actions[bot] Sep 13, 2023
c47a583
Restore more comparison in compare_stype4_data()
vchoi-hdfgroup Sep 13, 2023
b39b825
Committing clang-format changes
github-actions[bot] Sep 13, 2023
30d955a
Restore changes to test_select_dst_subset(): write/read/close dataset
vchoi-hdfgroup Sep 13, 2023
7a677c0
Turn on mwbuf, add more debugging printfs.
vchoi-hdfgroup Sep 13, 2023
ecf1586
Committing clang-format changes
github-actions[bot] Sep 13, 2023
1f5ca2b
Decrease the size of NY for debugging. Print out the element before …
vchoi-hdfgroup Sep 14, 2023
6b6cdac
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 14, 2023
4ab6ace
Committing clang-format changes
github-actions[bot] Sep 14, 2023
b50d9b5
Restore NX and set set_buf to always true.
vchoi-hdfgroup Sep 14, 2023
50b7483
Committing clang-format changes
github-actions[bot] Sep 14, 2023
5998ea7
Change NX x NY to 50x100; test all conditions including set_buf
vchoi-hdfgroup Sep 14, 2023
f296341
Restore NX x NY to 100 x 2000; Increase H5D_TEMP_BUF_SIZE
vchoi-hdfgroup Sep 14, 2023
c08c716
Correction.
vchoi-hdfgroup Sep 14, 2023
3ec8346
Restore H5D_TEMP_BUF_SIZE; add H5Pset_preserve() to the test.
vchoi-hdfgroup Sep 14, 2023
087080a
Committing clang-format changes
github-actions[bot] Sep 14, 2023
75e7dc5
Just test the chunked dataset in test_select_dst_subset()
vchoi-hdfgroup Sep 15, 2023
287ef6a
Committing clang-format changes
github-actions[bot] Sep 15, 2023
f9e08f6
Restore to test for both contig and chunked dataset
vchoi-hdfgroup Sep 15, 2023
fb34c5a
Change malloc() calls in test_select_dst_subset() in test/cmpd_dset.c…
vchoi-hdfgroup Sep 15, 2023
a7a7e93
Add debugging printfs in H5D__compound_opt_read().
vchoi-hdfgroup Sep 15, 2023
d0f3827
Committing clang-format changes
github-actions[bot] Sep 15, 2023
55cf96a
Corrections
vchoi-hdfgroup Sep 15, 2023
a009bb6
Committing clang-format changes
github-actions[bot] Sep 15, 2023
4b5480b
More debuggign printfs.
vchoi-hdfgroup Sep 16, 2023
627ea56
Committing clang-format changes
github-actions[bot] Sep 16, 2023
dcd085f
Corrections
vchoi-hdfgroup Sep 17, 2023
63485b3
Change to test for mbuf=true and set_buf=false always.
vchoi-hdfgroup Sep 17, 2023
a869d34
Test mbuf=true,false; set_buf=false
vchoi-hdfgroup Sep 18, 2023
759e3a1
Zero out the values in tconv_buf in H5Dscatgath_read().
vchoi-hdfgroup Sep 18, 2023
bdd608c
Committing clang-format changes
github-actions[bot] Sep 18, 2023
b2c3b08
Memset zero tconv_buf for compound read only. Remove debugging print…
vchoi-hdfgroup Sep 18, 2023
98fac7f
Committing clang-format changes
github-actions[bot] Sep 18, 2023
83ef7c2
--Use calloc for buffers in the selection I/O tests
vchoi-hdfgroup Sep 18, 2023
5c41bf8
Committing clang-format changes
github-actions[bot] Sep 18, 2023
058b769
Change the memset call again in H5Dscatgath_read()
vchoi-hdfgroup Sep 18, 2023
f1b5488
Committing clang-format changes
github-actions[bot] Sep 18, 2023
3cb4f97
Move memset to another location in H5Dcatgath_read().
vchoi-hdfgroup Sep 19, 2023
8c29ca9
Committing clang-format changes
github-actions[bot] Sep 19, 2023
9c72f3a
Restore the memset change
vchoi-hdfgroup Sep 19, 2023
d18041a
Committing clang-format changes
github-actions[bot] Sep 19, 2023
111b968
Print HOFFSET for the compound elements; remove memset in H5Dscatgath…
vchoi-hdfgroup Sep 19, 2023
1c7869d
Committing clang-format changes
github-actions[bot] Sep 19, 2023
dbaea29
Fix for the window CI test failure; restore some changes while debugg…
vchoi-hdfgroup Sep 19, 2023
fe92880
Merge branch 'develop_sel_io_test' of https://github.com/vchoi-hdfgro…
vchoi-hdfgroup Sep 19, 2023
f553c07
Committing clang-format changes
github-actions[bot] Sep 19, 2023
025edfc
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Sep 20, 2023
43d4563
Cleaning up the tests.
vchoi-hdfgroup Sep 20, 2023
3e6c4f0
Committing clang-format changes
github-actions[bot] Sep 20, 2023
b6b4c44
Update cmpd_dset.c
brtnfld Sep 21, 2023
6c4e8d3
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Sep 26, 2023
e1b4afc
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Sep 27, 2023
8d8e279
Add test to verify that the CI window failure is triggered and fixed.
vchoi-hdfgroup Sep 27, 2023
cf6519c
Committing clang-format changes
github-actions[bot] Sep 27, 2023
c57b347
Initialized the variables due to the CI gcc failures.
vchoi-hdfgroup Sep 27, 2023
fa795c4
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Oct 2, 2023
5af9b82
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Oct 3, 2023
b4f1c13
Modifications based on PR review comments.
vchoi-hdfgroup Oct 3, 2023
7deff0a
Committing clang-format changes
github-actions[bot] Oct 3, 2023
262c43c
Merge branch 'HDFGroup:develop' into develop_sel_io_test
vchoi-hdfgroup Oct 5, 2023
e222dc4
More changes based on PR review comments.
vchoi-hdfgroup Oct 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/H5Dscatgath.c
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ H5D__scatgath_write(const H5D_io_info_t *io_info, const H5D_dset_io_info_t *dset
/* Use "vp" field of union to twiddle away const. OK because if we're doing this it means the
* user explicitly allowed us to modify this buffer via H5Pset_modify_write_buf(). */
tmp_buf = (uint8_t *)dset_info->buf.vp + dset_info->layout_io_info.contig_piece_info->buf_off +
(smine_start * dset_info->type_info.dst_type_size);
(smine_start * dset_info->type_info.src_type_size);
}
else {
/* Do type conversion using intermediate buffer */
Expand Down
Loading