Add all float types to test #3501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
WIP
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
reviewed
Sep 14, 2023
| if (H5Dclose(dataset) < 0) | ||
| goto error; | ||
| } | ||
| #if 0 |
There was a problem hiding this comment.
And does this pass on Power? We have frequent long double issues there.
derobins
reviewed
Sep 14, 2023
| goto error; | ||
| } | ||
| #if 0 | ||
| #if H5_SIZEOF_LONG_DOUBLE != H5_SIZEOF_DOUBLE |
There was a problem hiding this comment.
I feel like we should run this even when long double and double are the same size.
There was a problem hiding this comment.
#if 0 because this is the test that needs fixed - the orig_data values need to be appropriate for long double (they are just copies of double from above).
|
Close in favor of #4060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 128 bit float test needs fixed