Updates CMake files to work with VFD SWMR #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CMake files were updated to build new files in src and test. - As with legacy SWMR, the test programs that are run via shell scripts are built but not run. - Updated whitespace in the links_env output file. It's unclear why this changed, but CMake does an exact diff on the file whereas the autotools do not.
|
@derobins - Did you want me to review? I could start looking at the vfd_swmr branch, possibly in pieces, but is it ready for that? |
jrmainzer
approved these changes
Oct 14, 2020
This is just a change to the CMake files in the VFD SWMR branch. It's not going into develop anytime soon. Feel free to review, but there's nothing interesting, library-wise, going on here :) |
byrnHDF
approved these changes
Oct 14, 2020
Closed
mattjala
pushed a commit
to mattjala/hdf5
that referenced
this pull request
Jan 3, 2025
…ug_fix H5I bug fix with some typo fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake files were updated to build new files in src and test.
As with legacy SWMR, the test programs that are run via shell
scripts are built but not run.
Updated whitespace in the links_env output file. It's unclear why
this changed, but CMake does an exact diff on the file whereas
the autotools do not.