Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Heap-buffer-overflow WRITE in H5MM_memcpy #3368

Merged
merged 2 commits into from
Aug 23, 2023
+7 −0
Merged

Fix Heap-buffer-overflow WRITE in H5MM_memcpy #3368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a2fae
Fix Heap-buffer-overflow WRITE in H5MM_memcpy
sashashura Aug 10, 2023
496e80e
Update RELEASE.txt
sashashura Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release_docs/RELEASE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,10 @@ Bug Fixes since HDF5-1.14.0 release

Fixes Github issue #3034

- Fixed write buffer overflow in H5O__alloc_chunk

The overflow was found by OSS-Fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58658

Java Library
------------
- Fixed switch case 'L' block missing a break statement.
Expand Down
3 changes: 3 additions & 0 deletions src/H5Oalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,9 @@ H5O__alloc_chunk(H5F_t *f, H5O_t *oh, size_t size, size_t found_null, const H5O_
else {
assert(curr_msg->type->id != H5O_CONT_ID);

if (size < curr_msg->raw_size + (size_t)H5O_SIZEOF_MSGHDR_OH(oh))
HGOTO_ERROR(H5E_OHDR, H5E_BADVALUE, FAIL, "invalid size");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make a sanitization pass over this whole function

/* Copy the raw data */
H5MM_memcpy(p, curr_msg->raw - (size_t)H5O_SIZEOF_MSGHDR_OH(oh),
curr_msg->raw_size + (size_t)H5O_SIZEOF_MSGHDR_OH(oh));
Expand Down