Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion failure in H5D__mpio_collective_filtered_vec_io (#3340) #3350

Merged
merged 1 commit into from
Aug 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/H5Dmpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -5489,6 +5489,9 @@ H5D__mpio_collective_filtered_vec_io(const H5D_filtered_collective_io_info_t *ch
for (size_t i = 0, vec_idx = 0; i < chunk_list->num_chunk_infos; i++) {
H5F_block_t *chunk_block;

if (op_type == H5D_IO_OP_READ && !chunk_list->chunk_infos[i].need_read)
continue;

/*
* Check that we aren't going to accidentally try to write past the
* allocated memory for the I/O vector buffers in case bookkeeping
Expand All @@ -5497,9 +5500,6 @@ H5D__mpio_collective_filtered_vec_io(const H5D_filtered_collective_io_info_t *ch
*/
assert(vec_idx < iovec_count);

if (op_type == H5D_IO_OP_READ && !chunk_list->chunk_infos[i].need_read)
continue;

/* Set convenience pointer for current chunk block */
chunk_block = (op_type == H5D_IO_OP_READ) ? &chunk_list->chunk_infos[i].chunk_current
: &chunk_list->chunk_infos[i].chunk_new;
Expand Down