Update supported platforms #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
bljhdf,
derobins,
fortnern,
jhendersonHDF,
jrmainzer,
lrknox,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
|
Why all the whitespace changes? I'm pretty sure the one in H5TS.c is considered incorrect and is driving us insane. |
Because the action check flags those. I thought Dana fixed it, but maybe his PR didn't get merged? |
|
It hasn’t been merged. Quincey requested changes and is looking at a different solution.
From: Allen Byrne <[email protected]>
Sent: Tuesday, February 02, 2021 1:01 PM
To: HDFGroup/hdf5 <[email protected]>
Cc: Larry Knox <[email protected]>; Review requested <[email protected]>
Subject: Re: [HDFGroup/hdf5] Update supported platforms (#303)
Why all the whitespace changes? I'm pretty sure the one in H5TS.c is considered incorrect and is driving us insane.
Because the action check flags those. I thought Dana fixed it, but maybe his PR didn't get merged?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#303 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCX3VRR3JYS2HRZUR7TS5BDVZANCNFSM4W6YLQWQ>.
|
lrknox
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some minor whitespace corrections