Fix new codespell issues #2521
Merged
Fix new codespell issues #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitti
requested review from
brtnfld,
derobins,
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
mattjala
as code owners
|
I see you've already created a PR to fix.
I think we need to add ndefined to the list to be skipped in .github/workflows/codespell.yaml. It is part of [Uu]ndefined in cmake sanitzer code, so it is correct. There is one more misspelled word in doxygen/examples/Fileformat.html:33 - knowledgable needs e before able.
…________________________________
From: Mark Kittisopikul ***@***.***>
Sent: Wednesday, March 8, 2023 1:56 PM
To: HDFGroup/hdf5 ***@***.***>
Cc: Larry Knox ***@***.***>; Review requested ***@***.***>
Subject: Re: [HDFGroup/hdf5] Fix new codespell issues (PR #2521)
@mkitti<https://github.com/mkitti> requested your review on: #2521<#2521> Fix new codespell issues as a code owner.
—
Reply to this email directly, view it on GitHub<#2521 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCVFKCPBQUEO2NSQ2KLW3DP7LANCNFSM6AAAAAAVUGEBDE>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
mkitti
force-pushed
the
mkitti/codespell_fixes
branch
from
4ed1582 to
a469172
Compare
|
@mkitti, do you want to add ndefined to the ignore_words_list in .github/workflows.codespell.yaml? |
|
Hmm... |
Sure. You'll add it to the "skip:" list in codespell.yaml? |
lrknox
approved these changes
Mar 8, 2023
byrnHDF
approved these changes
Mar 8, 2023
byrnHDF
added
the
Type - Improvement
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Mar 9, 2023
* Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake
lrknox
added a commit
that referenced
this pull request
Mar 9, 2023
* Fix new codespell issues (#2521) * Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake * Fix typo in genparser --------- Co-authored-by: Mark Kittisopikul <[email protected]>
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Mar 10, 2023
* Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake
byrnHDF
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Fix new codespell issues (#2521) * Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake * Fix typo in genparser. --------- Co-authored-by: Mark Kittisopikul <[email protected]>
lrknox
pushed a commit
to lrknox/hdf5
that referenced
this pull request
Mar 10, 2023
* Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake
byrnHDF
pushed a commit
that referenced
this pull request
Mar 10, 2023
* Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake Co-authored-by: Mark Kittisopikul <[email protected]>
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
May 17, 2023
* Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 5, 2023
* Fix new codespell issues (HDFGroup#2521) * Fix new codespell issues * Have codespell ignore ./config/sanitizer/sanitizers.cmake * Fix typo in genparser. --------- Co-authored-by: Mark Kittisopikul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.