-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port h5dchunk_iter_hsizet_size #2074 to hdf5_1_12 branch #2329
Port h5dchunk_iter_hsizet_size #2074 to hdf5_1_12 branch #2329
Conversation
…up#2074) * Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info * Modify chunk_info test to for unsigned / hsize_t types * Fix types in test * Port of HDFGroup#2074 to hdf5_1_12 branch
The failed test was due to the mirror VFD test not being able to connect to a socket. We see this test failure on GitHub from time to time. Re-running the failed tests fixes the problem so we think it's a GitHub issue. |
Note that we should also update the doxygen example as in #2380 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me here; just minor nitpicks
Could we have some determination on #2380 ? I would prefer to keep the documentation in sync with the code if possible. |
That's probably more of a question for @derobins or @byrnHDF, but I'll note that to address that first warning the example should probably use the |
… H5D.c Forward port of 9f252f1 from HDFGroup#2329
I plan on pulling the Doxygen example correction from https://github.com/HDFGroup/hdf5/pull/2380/files#diff-a8a358e3ee19fd11ac351047b6fd4d25f291254c986970da70fbbebb69d0ce39 into this pull request, without the changes to cmake. |
… H5D.c (HDFGroup#2512) Forward port of 9f252f1 from HDFGroup#2329
… H5D.c (#2512) (#2566) Forward port of 9f252f1 from #2329 Co-authored-by: Mark Kittisopikul <[email protected]>
… H5D.c (HDFGroup#2512) Forward port of 9f252f1 from HDFGroup#2329
Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info
Modify chunk_info test to for unsigned / hsize_t types
Fix types in test
Port of Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info #2074 to hdf5_1_12 branch
cc: @derobins