Fix memory leak in H5PL__find_plugin_in_path #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering a directory, the current loop iteration was skipped without freeing the memory allocated for the path.
michaelkuhn
requested review from
derobins,
fortnern,
jhendersonHDF,
qkoziol,
soumagne,
vchoi-hdfgroup and
jrmainzer
as code owners
|
The test on Windows fails due to another problem in the hdf5_1_12 branch. The test won't pass until that is fixed. It should be fixed in a few days or so. We will add another comment at that time, and you can either update your fork with the changes or I can create a new PR.. |
|
Actually, the change in this PR is also in PR #13. When hdf5_1_12 passes the code change will come in through that PR. |
|
This change will be merged as part of PR #28, along with changes to make the test pass. Thanks! |
Closed
mattjala
added a commit
to mattjala/hdf5
that referenced
this pull request
Dec 17, 2024
Fix typo in H5pubconf for multithread build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I could not find anything on the 1.12 branch, here is a backport of #16.
When encountering a directory, the current loop iteration was skipped without freeing the memory allocated for the path.