Fix memory bug in selection I/O #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortnern
requested review from
lrknox,
derobins,
byrnHDF,
jhendersonHDF,
ChristopherHogan,
qkoziol,
vchoi-hdfgroup,
bmribler and
raylu-hdf
as code owners
bmribler
reviewed
Sep 12, 2022
H5FD_read/write_selection()
byrnHDF
approved these changes
Sep 12, 2022
jhendersonHDF
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H5FD_read/write_selection() is passed an array of H5S_t *s and in some cases needs to create to pass an array of hid_ts referencing these H5S_t *s to the underlying callback. The function does this using H5I_register(). When freeing memory at the end of the function, it would previously call H5I_dec_app_ref on the ids, which had the side effect of freeing the H5S_t *s, even though they were not created by H5FD_read/write_selection(), causing problems when the calling function(s) tried to use these spaces afterwards. Changed to H5I_remove().