Fix VFD h5repacktest #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering a directory, the current loop iteration was skipped without freeing the memory allocated for the path.
byrnHDF
requested review from
fortnern,
jhendersonHDF,
qkoziol,
soumagne,
vchoi-hdfgroup,
bmribler and
jrmainzer
as code owners
derobins
reviewed
Oct 5, 2020
|
|
||
| return yy_scan_bytes(yystr, (int)strlen(yystr)); | ||
| } | ||
| yy_scan_string(const char *yystr) { return yy_scan_bytes(yystr, (int)strlen(yystr)); } | ||
|
|
There was a problem hiding this comment.
Is this due to running the formatter over this file?
There was a problem hiding this comment.
Yes, I thought I had this file excluded.
There was a problem hiding this comment.
It is excluded in the yaml, just not in the bin scripts. I'll fix that.
There was a problem hiding this comment.
I can't seem to find a previous version, but it shouldn't matter much as it should be the same after formatting.
derobins
approved these changes
Oct 5, 2020
jhendersonHDF
approved these changes
Oct 5, 2020
lrknox
approved these changes
Oct 5, 2020
qkoziol
approved these changes
Oct 5, 2020
bmribler
approved these changes
Oct 6, 2020
vchoi-hdfgroup
added a commit
that referenced
this pull request
Jun 11, 2021
VFD SWMR: sync with develop (#725)
Closed
mattjala
added a commit
to mattjala/hdf5
that referenced
this pull request
Dec 17, 2024
…list Prevent H5Pset_vol from changing default VOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
double free failure in repacktest
also some formatting changes