Backport H5Dchunk_iter to 1.10 branch #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkitti
requested review from
jhendersonHDF,
fortnern,
soumagne,
vchoi-hdfgroup,
ChristopherHogan,
gnuoyd,
derobins,
jrmainzer and
lrknox
as code owners
|
The test failure encountered in #666 may be an issue here as well |
|
This needs to go to 1.12 first. We move features down the chain of maintenance branches. |
1 task
…up#2074) * Align arg types of H5D_chunk_iter_op_t with H5Dget_chunk_info * Modify chunk_info test to for unsigned / hsize_t types * Fix types in test
mkitti
force-pushed
the
mkitti/h5dchunk_iter_1_10
branch
from
d26e528 to
9b3a35b
Compare
…FGroup#1419 (HDFGroup#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix HDFGroup#1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist
…to mkitti/h5dchunk_iter_1_10
mkitti
commented
Dec 21, 2022
Comment on lines
+1964
to
+1968
| /* In HDF5 1.10 this will not fail. It will fail in 1.12 and older. */ | ||
| /* | ||
| if (ret != FAIL) | ||
| TEST_ERROR; | ||
| */ |
There was a problem hiding this comment.
Trying to fix this creates new issues on HDF5 1.10.
|
I backported the I noticed some difference in return value behavior of Since the HDF5 1.12 version of |
byrnHDF
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports H5Dchunk_iter #6 to the 1.10 branch from the 1.13 development branch.
xref: https://forum.hdfgroup.org/t/possibility-of-backporting-h5dchunk-iter-to-1-12/9971/2
To do:
test/chunk_iter.cH5Dchunk_iterto 1.12: Backport H5Dchunk_iter to 1.12 branch #1970