Minor tweaks from VFD SWMR normalization #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derobins
requested review from
jhendersonHDF,
fortnern,
soumagne,
vchoi-hdfgroup,
ChristopherHogan,
gnuoyd,
jrmainzer,
qkoziol and
lrknox
as code owners
derobins
commented
Mar 8, 2022
| @@ -928,9 +928,10 @@ H5FD_cmp(const H5FD_t *f1, const H5FD_t *f2) | |||
| { | |||
| int ret_value = -1; /* Return value */ | |||
|
|
|||
| FUNC_ENTER_NOAPI_NOERR /* return value is arbitrary */ | |||
| FUNC_ENTER_NOAPI_NOERR; /* return value is arbitrary */ | |||
There was a problem hiding this comment.
The semicolon here prevents the formatter from botching the subsequent lines of code.
derobins
commented
Mar 8, 2022
| @@ -1127,7 +1127,7 @@ H5T_open(const H5G_loc_t *loc) | |||
| done: | |||
| if (ret_value == NULL) { | |||
| if (dt) { | |||
| if (shared_fo == NULL) { /* Need to free shared of */ | |||
| if (shared_fo == NULL) { /* Need to free shared file object */ | |||
There was a problem hiding this comment.
codespell changed 'fo' (file object) to 'of'
soumagne
approved these changes
Mar 9, 2022
lrknox
approved these changes
Mar 9, 2022
gnuoyd
pushed a commit
that referenced
this pull request
Mar 9, 2022
mkitti
added a commit
to mkitti/hdf5
that referenced
this pull request
Aug 8, 2022
1 task
derobins
added a commit
that referenced
this pull request
Aug 16, 2022
* Revert "Revert H5Dchunk_iter changes in hdf5_1_12_1 (#733)" This reverts commit 10abe9a. * Apply clang-format * Reincorporate spelling fix from #1166 * Incorporate H5Dchunk_iter changes from #161 * Backport to 1.12: Adds a quick for for some egregious chunk_info badness (#722) * Backport to 1.12: Converts testhdf5 macros to h5test macros in chunk_info.c (#1820) The two macro schemes were not designed to work together. Also quiets some MSVC warnings about comparing pointers and integers. * Backport to 1.12: H5Dchunk_iter now passes offsets in units of dataset elements, fix #1419 (#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix #1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist * Sync H5Dchunk_iter documentation with develop * Remove H5VL_DATASET_WAIT references from 1.12 * Backport to 1.12 #161, #1474, review comments Co-authored-by: Dana Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.