Fix ASAN issue in h5dump error path (#1051)

* Fix ASAN issue in h5dump error path * Rework error allocation free.
HDFGroup · Oct 3, 2021 · eca8d5b · eca8d5b
1 parent b3cb56e
commit eca8d5b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/tools/lib/h5tools_utils.c b/tools/lib/h5tools_utils.c
@@ -450,6 +450,7 @@ free_table(table_t *table)
             HDfree(table->objs[u].objname);
 
     HDfree(table->objs);
+    HDfree(table);
 }
 
 #ifdef H5DUMP_DEBUG

diff --git a/tools/src/h5dump/h5dump.c b/tools/src/h5dump/h5dump.c
@@ -465,11 +465,8 @@ table_list_free(void)
 
         /* Free each table */
         free_table(table_list.tables[u].group_table);
-        HDfree(table_list.tables[u].group_table);
         free_table(table_list.tables[u].dset_table);
-        HDfree(table_list.tables[u].dset_table);
         free_table(table_list.tables[u].type_table);
-        HDfree(table_list.tables[u].type_table);
     }
 
     /* Free the table list */