Skip to content

Commit

Permalink
Merge issue 839 develop PRs to hdf5 1 10 - round 2 (#852)
Browse files Browse the repository at this point in the history
* Revert addition of & to 2 parameters in DSetCreatPropList::setVirtual to
maintain binary compatibility.

* Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)

* Removes gratuitous (double)x.yF casts (#632)

* Committing clang-format changes

* Removes gratuitous (double)x.yF casts

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Cleans up a const warning left over from previous constification (#633)

* Committing clang-format changes

* Adds consts to a few global variables

* Cleans up a const warning left over from previous constification

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Purges UFAIL from the library (#637)

* Committing clang-format changes

* Purges UFAIL from the library

* H5HL_insert change requested in PR

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Bmr dev hdffv 11223 (#640)

* Fixed HDFFV-11223 (CVE-2018-14460)

Description
    - Added checks against buffer size to prevent segfault, in case of data
      corruption, for sdim->size and sdim->max.
    - Renamed data files in an existing test to shorten their length
      as agreed with other developers previously.
Platforms tested:
    Linux/64 (jelly)

* Committing clang-format changes

* Updated for test files

* Updated for HDFFV-11223

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Committing clang-format changes

* Restore "error:" in line 2666.

* Revert "Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)"

This reverts commit 426b50484841118cf633fd6147302a63a30fd746.

* Snapshot version 1.10 release 8-1. Update version to 1.10.8-2.

Squashed commit of the following:

commit 60734e63fe077238f10de3d6ca8f037f9a42af89
Author: Allen Byrne <[email protected]>
Date:   Thu Jun 24 14:20:39 2021 -0500

    Hdf5 1 10 Fix tools test (#796)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    * Merge warnings files fixes from develop

    * Fix cmake configure path

    * Update missing release note info.

    * Update code owners

    * Add known problem

    * Use only core library for testing dynamic plugins.

    CMake uses H5_HAVE_DIRECT instead of DIRECT_VFD

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit bfb780a4441e4ef43dd23708d415e5e3b84800f4
Author: Allen Byrne <[email protected]>
Date:   Wed Jun 23 14:11:46 2021 -0500

    Hdf5 1 10 Release Note (#786)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    * Merge warnings files fixes from develop

    * Fix cmake configure path

    * Update missing release note info.

    * Update code owners

    * Add known problem

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit 9f5040736868f8eec584ab5af6d2a77e4d45ae30
Author: Allen Byrne <[email protected]>
Date:   Tue Jun 22 07:03:26 2021 -0500

    Hdf5 1 10 Update missing release note info. (#778)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    * Merge warnings files fixes from develop

    * Fix cmake configure path

    * Update missing release note info.

    * Update code owners

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit 2e80c9cdec98d6cee5b4609643839a4ad2a848fb
Author: Dana Robinson <[email protected]>
Date:   Fri Jun 18 06:42:23 2021 -0700

    Brings hash table IDs feature from develop/1.12 (#768)

    * Brings updated tid test from develop

    * Adds empty H5Iint.c and H5Idbg.c files

    * H5I renaming to match 1.12/develop

    * Splits off H5I debug code to H5Idbg.c

    * Splits internal H5I.c functionality to H5Iint.c

    * Header cleanup

    * More renaming cleanup to match develop/1.12

    * Adds "save last ID" optimization

    * Adds uthash.h

    * Adds hash table IDs from develop/1.12

    * Committing clang-format changes

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit 1e29bcbfe24956f0158b3363a3fbb8a42c8e7e0f
Author: Allen Byrne <[email protected]>
Date:   Thu Jun 17 11:21:43 2021 -0500

    Hdf5 1 10 Fix cmake configure path (#762)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    * Merge warnings files fixes from develop

    * Fix cmake configure path

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit 475cdaf431c9ef5bfef6243dbc26d0005d08c49d
Author: Allen Byrne <[email protected]>
Date:   Wed Jun 16 15:45:58 2021 -0500

    Hdf5 1 10 merge warnings changes (#756)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    * Merge warnings files fixes from develop

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit e25980e7f35b8508db90648409ba80ee36d61c9e
Author: Allen Byrne <[email protected]>
Date:   Tue Jun 8 14:37:13 2021 -0500

    Hdf5 1 10 merges of CMake changes (#738)

    * HDFFV-10865 - merge from dev, HDFArray perf fix.

    * Remove duplicate setting

    * Whitespace changes after clang format

    * Undo version 11 clang format changes

    * Merge CMake changes from develop

    * test testing script merge from develop

    * Update supported platforms

    * PR#3 merge from develop

    * Merge gcc 10 diagnostics option from develop

    * Merge #318 OSX changes from develop

    * Merge small changes from develop

    * Minor non-space formatting changes

    * #386 copyright corrections for java folder

    * Merges from develop

    #358 patches from vtk
    #361 fix header guard spelling

    * Merge updates

    #358 patches from vtk
    #361 fix header guard spelling

    * format fix

    * Fix missing underscore and make H5public.h closer to dev

    * Merges from develop

    #340 clang -Wformat-security warnings
    #360 Fixed uninitialized warnings
    header guard underscore cleanup
    JNI cleanup

    * format alignment

    * Add missing test ref file

    * Merge #380 from develop

    * Finish java merges from develop

    * Fix java issues with tests and javadoc

    * Correct use of attribute access plist

    * Remove debug code

    * Remove unused variable

    * Change file access to read only for java tests

    * Split clang format operations.

    * More javadoc comments

    * Remove pre-split setting

    * format source

    * Change windows TS to use older VS.

    * Mostly all javadoc fixes, one argument rename.

    * synch file

    * Merge of long double fix and compiler flags

    * HDFFV-11229 merge changes from develop

    * HDFFV-11229 correct test script

    * HDFFV-11229 update autotools test script for two ref files

    * HDFFV-11229 merge dev changes for long double display in tools

    * Committing clang-format changes

    * minor whitespace

    * remove unneeded macro

    * Committing clang-format changes

    * Add "option" command for clang options

    * Rework CMake add_custom to use the BYPRODUCTS argument

    Update pkgconfig scripts for parallel builds.
    Fix install COPYING file reference.
    Remove unused round defines.
    Change CMake default setting of BUILD_CPP to off.

    * Fortran target depends

    * Remove incorrect source attribute

    * Revert define removal

    * printf specifiers and VS2015 min changes

    * Committing clang-format changes

    * Add time struct

    * TRILAB-227 and tools debug merges from develop

    * Merge various changes from dev

    * Issue #669 remove version from pkgcfg filename

    * remove version from h5cc script

    * doxygen changes merged from develop

    * Committing clang-format changes

    * Merge CMake fortran ninja changes from dev

    * Enable fortran to gcc yaml

    * Refactor Fortran CMake config tests and CMake test args

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

commit 061b23ac0011d3a26f660a7f4d07c40f41d63f10
Author: Larry Knox <[email protected]>
Date:   Thu Jun 3 16:07:23 2021 -0500

    Partial merge issue #642 develop branch PRs to Hdf5 1 10 (#718)

    * Revert addition of & to 2 parameters in DSetCreatPropList::setVirtual to
    maintain binary compatibility.

    * Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)

    * Removes gratuitous (double)x.yF casts (#632)

    * Committing clang-format changes

    * Removes gratuitous (double)x.yF casts

    * Committing clang-format changes

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Cleans up a const warning left over from previous constification (#633)

    * Committing clang-format changes

    * Adds consts to a few global variables

    * Cleans up a const warning left over from previous constification

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Purges UFAIL from the library (#637)

    * Committing clang-format changes

    * Purges UFAIL from the library

    * H5HL_insert change requested in PR

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Bmr dev hdffv 11223 (#640)

    * Fixed HDFFV-11223 (CVE-2018-14460)

    Description
        - Added checks against buffer size to prevent segfault, in case of data
          corruption, for sdim->size and sdim->max.
        - Renamed data files in an existing test to shorten their length
          as agreed with other developers previously.
    Platforms tested:
        Linux/64 (jelly)

    * Committing clang-format changes

    * Updated for test files

    * Updated for HDFFV-11223

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Committing clang-format changes

    * Restore "error:" in line 2666.

    * Revert "Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)"

    This reverts commit 426b50484841118cf633fd6147302a63a30fd746.

    Co-authored-by: jhendersonHDF <[email protected]>
    Co-authored-by: Dana Robinson <[email protected]>
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: bmribler <[email protected]>

* (fix) Segmentation fault when using a compound type. (#143)

* (fix) Segmentation fault when using a compound type.

In the case when a compounded attribute is written to dataset
followed by writing the data with a data transform function
to the dataset will result in a segmentation fault. It turns out
the data is classified as compounded while it is not. Now, the
state is always reset first to not compounded followed by the
existing check if the variable is compounded.

* (fix) Removed undesired comment lines.

* (fix) Segmentation fault when using a compound type: added test.

* (fix) Added the missing cmpd_transform.c file to MANIFEST.

* (fix) cmpd_dtransform test: autotools and source header.

Added the cmp_dtransform test to the autotools configuration and
updated the HDF Group copyright header.

Co-authored-by: Jan-Willem Blokland <[email protected]>

* (fix) H5Z_xform_create function and scientific notation (#144)

* (fix) H5Z_xform_create function and scientific notation

Implemented a more sophisticated check to support scientific notation
in the expression of the H5Zset_data_transform function.

* (fix) H5Z_xform_create and scientific notation: Added test.

Added a test to demonstrate that the parsing of expression
which includes scientific notation works correctly. Improved
inline comment.

Co-authored-by: Jan-Willem Blokland <[email protected]>

* Adds const to a few global variables (#623)

* Committing clang-format changes

* Adds consts to a few global variables

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Made private my_yyinput function static (#618)

This prevents it being exported as a public symbol.

* Reduces overly-pedantic casting in the public headers (#644)

* Committing clang-format changes

* Fixes overly pedantic casting in public headers

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Use internal version of H5Eprint2 to avoid possible stack overflow (#661)

* Fixes for a couple of trivial warnings (#676)

* Committing clang-format changes

* Trivial warning fixes:

* Removes an unused done target in H5Tbit.c
* Add (void) to quiet "ignored return value" warnings in the generators
  (which generally ignore errors)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Removes alternative function enter/leave macro scheme (#678)

* Committing clang-format changes

* Converted BEGIN_FUNC, etc. macros to FUNC_ENTER

* Rips out the BEGIN_FUNC, etc. macros

* Removes 'end if', etc. comments from H5HL package

* Committing clang-format changes

* Fixes an H5EA iterate issue

* Fixes an issue in the H5FA iterator code

* Further cleanup in bin/trace after macro removal

* Iterator changes in H5EA and H5FA

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Various CMake changes (#679)

* Committing clang-format changes

* Several CMake updates:

* Removes unused HDF5_ENABLE_HSIZET
* Switches TEST_SHELL_SCRIPTS to ON
* Sets SH_PROGRAM to bash instead of sh

* Set default build type back to RelWithDebInfo

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Revert "Removes alternative function enter/leave macro scheme (#678)"

This reverts commit edddb11b791adbdcaafed3ba718c95dd349a4e9a.

* err_compat test cleanup (#681)

* Committing clang-format changes

* Cleans up err_compat test and output

* Formatted source

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Sets the memory alloc sanity check option to disabled in autotools (#686)

* Revert "Sets the memory alloc sanity check option to disabled in autotools (#686)"

This reverts commit 652ffca58699388fff960c6a92c8ecfd1fc5d19b.

(Only for release branch).

* Removes alternative function enter/leave macro scheme (#678)

* Committing clang-format changes

* Converted BEGIN_FUNC, etc. macros to FUNC_ENTER

* Rips out the BEGIN_FUNC, etc. macros

* Removes 'end if', etc. comments from H5HL package

* Committing clang-format changes

* Fixes an H5EA iterate issue

* Fixes an issue in the H5FA iterator code

* Further cleanup in bin/trace after macro removal

* Iterator changes in H5EA and H5FA

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Committing clang-format changes

* Squashed commit of the following:

commit e2578640fedf671cf11535cf22313dd477da1165
Author: Larry Knox <[email protected]>
Date:   Fri Jul 16 10:57:51 2021 -0500

    Merge issue 839 changes to hdf5 1 10 (#841)

    * Revert addition of & to 2 parameters in DSetCreatPropList::setVirtual to
    maintain binary compatibility.

    * Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)

    * Removes gratuitous (double)x.yF casts (#632)

    * Committing clang-format changes

    * Removes gratuitous (double)x.yF casts

    * Committing clang-format changes

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Cleans up a const warning left over from previous constification (#633)

    * Committing clang-format changes

    * Adds consts to a few global variables

    * Cleans up a const warning left over from previous constification

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Purges UFAIL from the library (#637)

    * Committing clang-format changes

    * Purges UFAIL from the library

    * H5HL_insert change requested in PR

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Bmr dev hdffv 11223 (#640)

    * Fixed HDFFV-11223 (CVE-2018-14460)

    Description
        - Added checks against buffer size to prevent segfault, in case of data
          corruption, for sdim->size and sdim->max.
        - Renamed data files in an existing test to shorten their length
          as agreed with other developers previously.
    Platforms tested:
        Linux/64 (jelly)

    * Committing clang-format changes

    * Updated for test files

    * Updated for HDFFV-11223

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Committing clang-format changes

    * Restore "error:" in line 2666.

    * Revert "Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)"

    This reverts commit 426b50484841118cf633fd6147302a63a30fd746.

    * Snapshot version 1.10 release 8-1. Update version to 1.10.8-2.

    Squashed commit of the following:

    commit 60734e63fe077238f10de3d6ca8f037f9a42af89
    Author: Allen Byrne <[email protected]>
    Date:   Thu Jun 24 14:20:39 2021 -0500

        Hdf5 1 10 Fix tools test (#796)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        * Merge warnings files fixes from develop

        * Fix cmake configure path

        * Update missing release note info.

        * Update code owners

        * Add known problem

        * Use only core library for testing dynamic plugins.

        CMake uses H5_HAVE_DIRECT instead of DIRECT_VFD

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit bfb780a4441e4ef43dd23708d415e5e3b84800f4
    Author: Allen Byrne <[email protected]>
    Date:   Wed Jun 23 14:11:46 2021 -0500

        Hdf5 1 10 Release Note (#786)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        * Merge warnings files fixes from develop

        * Fix cmake configure path

        * Update missing release note info.

        * Update code owners

        * Add known problem

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit 9f5040736868f8eec584ab5af6d2a77e4d45ae30
    Author: Allen Byrne <[email protected]>
    Date:   Tue Jun 22 07:03:26 2021 -0500

        Hdf5 1 10 Update missing release note info. (#778)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        * Merge warnings files fixes from develop

        * Fix cmake configure path

        * Update missing release note info.

        * Update code owners

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit 2e80c9cdec98d6cee5b4609643839a4ad2a848fb
    Author: Dana Robinson <[email protected]>
    Date:   Fri Jun 18 06:42:23 2021 -0700

        Brings hash table IDs feature from develop/1.12 (#768)

        * Brings updated tid test from develop

        * Adds empty H5Iint.c and H5Idbg.c files

        * H5I renaming to match 1.12/develop

        * Splits off H5I debug code to H5Idbg.c

        * Splits internal H5I.c functionality to H5Iint.c

        * Header cleanup

        * More renaming cleanup to match develop/1.12

        * Adds "save last ID" optimization

        * Adds uthash.h

        * Adds hash table IDs from develop/1.12

        * Committing clang-format changes

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit 1e29bcbfe24956f0158b3363a3fbb8a42c8e7e0f
    Author: Allen Byrne <[email protected]>
    Date:   Thu Jun 17 11:21:43 2021 -0500

        Hdf5 1 10 Fix cmake configure path (#762)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        * Merge warnings files fixes from develop

        * Fix cmake configure path

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit 475cdaf431c9ef5bfef6243dbc26d0005d08c49d
    Author: Allen Byrne <[email protected]>
    Date:   Wed Jun 16 15:45:58 2021 -0500

        Hdf5 1 10 merge warnings changes (#756)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        * Merge warnings files fixes from develop

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit e25980e7f35b8508db90648409ba80ee36d61c9e
    Author: Allen Byrne <[email protected]>
    Date:   Tue Jun 8 14:37:13 2021 -0500

        Hdf5 1 10 merges of CMake changes (#738)

        * HDFFV-10865 - merge from dev, HDFArray perf fix.

        * Remove duplicate setting

        * Whitespace changes after clang format

        * Undo version 11 clang format changes

        * Merge CMake changes from develop

        * test testing script merge from develop

        * Update supported platforms

        * PR#3 merge from develop

        * Merge gcc 10 diagnostics option from develop

        * Merge #318 OSX changes from develop

        * Merge small changes from develop

        * Minor non-space formatting changes

        * #386 copyright corrections for java folder

        * Merges from develop

        #358 patches from vtk
        #361 fix header guard spelling

        * Merge updates

        #358 patches from vtk
        #361 fix header guard spelling

        * format fix

        * Fix missing underscore and make H5public.h closer to dev

        * Merges from develop

        #340 clang -Wformat-security warnings
        #360 Fixed uninitialized warnings
        header guard underscore cleanup
        JNI cleanup

        * format alignment

        * Add missing test ref file

        * Merge #380 from develop

        * Finish java merges from develop

        * Fix java issues with tests and javadoc

        * Correct use of attribute access plist

        * Remove debug code

        * Remove unused variable

        * Change file access to read only for java tests

        * Split clang format operations.

        * More javadoc comments

        * Remove pre-split setting

        * format source

        * Change windows TS to use older VS.

        * Mostly all javadoc fixes, one argument rename.

        * synch file

        * Merge of long double fix and compiler flags

        * HDFFV-11229 merge changes from develop

        * HDFFV-11229 correct test script

        * HDFFV-11229 update autotools test script for two ref files

        * HDFFV-11229 merge dev changes for long double display in tools

        * Committing clang-format changes

        * minor whitespace

        * remove unneeded macro

        * Committing clang-format changes

        * Add "option" command for clang options

        * Rework CMake add_custom to use the BYPRODUCTS argument

        Update pkgconfig scripts for parallel builds.
        Fix install COPYING file reference.
        Remove unused round defines.
        Change CMake default setting of BUILD_CPP to off.

        * Fortran target depends

        * Remove incorrect source attribute

        * Revert define removal

        * printf specifiers and VS2015 min changes

        * Committing clang-format changes

        * Add time struct

        * TRILAB-227 and tools debug merges from develop

        * Merge various changes from dev

        * Issue #669 remove version from pkgcfg filename

        * remove version from h5cc script

        * doxygen changes merged from develop

        * Committing clang-format changes

        * Merge CMake fortran ninja changes from dev

        * Enable fortran to gcc yaml

        * Refactor Fortran CMake config tests and CMake test args

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    commit 061b23ac0011d3a26f660a7f4d07c40f41d63f10
    Author: Larry Knox <[email protected]>
    Date:   Thu Jun 3 16:07:23 2021 -0500

        Partial merge issue #642 develop branch PRs to Hdf5 1 10 (#718)

        * Revert addition of & to 2 parameters in DSetCreatPropList::setVirtual to
        maintain binary compatibility.

        * Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)

        * Removes gratuitous (double)x.yF casts (#632)

        * Committing clang-format changes

        * Removes gratuitous (double)x.yF casts

        * Committing clang-format changes

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

        * Cleans up a const warning left over from previous constification (#633)

        * Committing clang-format changes

        * Adds consts to a few global variables

        * Cleans up a const warning left over from previous constification

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

        * Purges UFAIL from the library (#637)

        * Committing clang-format changes

        * Purges UFAIL from the library

        * H5HL_insert change requested in PR

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

        * Bmr dev hdffv 11223 (#640)

        * Fixed HDFFV-11223 (CVE-2018-14460)

        Description
            - Added checks against buffer size to prevent segfault, in case of data
              corruption, for sdim->size and sdim->max.
            - Renamed data files in an existing test to shorten their length
              as agreed with other developers previously.
        Platforms tested:
            Linux/64 (jelly)

        * Committing clang-format changes

        * Updated for test files

        * Updated for HDFFV-11223

        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

        * Committing clang-format changes

        * Restore "error:" in line 2666.

        * Revert "Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)"

        This reverts commit 426b50484841118cf633fd6147302a63a30fd746.

        Co-authored-by: jhendersonHDF <[email protected]>
        Co-authored-by: Dana Robinson <[email protected]>
        Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
        Co-authored-by: bmribler <[email protected]>

    * (fix) Segmentation fault when using a compound type. (#143)

    * (fix) Segmentation fault when using a compound type.

    In the case when a compounded attribute is written to dataset
    followed by writing the data with a data transform function
    to the dataset will result in a segmentation fault. It turns out
    the data is classified as compounded while it is not. Now, the
    state is always reset first to not compounded followed by the
    existing check if the variable is compounded.

    * (fix) Removed undesired comment lines.

    * (fix) Segmentation fault when using a compound type: added test.

    * (fix) Added the missing cmpd_transform.c file to MANIFEST.

    * (fix) cmpd_dtransform test: autotools and source header.

    Added the cmp_dtransform test to the autotools configuration and
    updated the HDF Group copyright header.

    Co-authored-by: Jan-Willem Blokland <[email protected]>

    * (fix) H5Z_xform_create function and scientific notation (#144)

    * (fix) H5Z_xform_create function and scientific notation

    Implemented a more sophisticated check to support scientific notation
    in the expression of the H5Zset_data_transform function.

    * (fix) H5Z_xform_create and scientific notation: Added test.

    Added a test to demonstrate that the parsing of expression
    which includes scientific notation works correctly. Improved
    inline comment.

    Co-authored-by: Jan-Willem Blokland <[email protected]>

    * Adds const to a few global variables (#623)

    * Committing clang-format changes

    * Adds consts to a few global variables

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Made private my_yyinput function static (#618)

    This prevents it being exported as a public symbol.

    * Reduces overly-pedantic casting in the public headers (#644)

    * Committing clang-format changes

    * Fixes overly pedantic casting in public headers

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Use internal version of H5Eprint2 to avoid possible stack overflow (#661)

    * Fixes for a couple of trivial warnings (#676)

    * Committing clang-format changes

    * Trivial warning fixes:

    * Removes an unused done target in H5Tbit.c
    * Add (void) to quiet "ignored return value" warnings in the generators
      (which generally ignore errors)

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Removes alternative function enter/leave macro scheme (#678)

    * Committing clang-format changes

    * Converted BEGIN_FUNC, etc. macros to FUNC_ENTER

    * Rips out the BEGIN_FUNC, etc. macros

    * Removes 'end if', etc. comments from H5HL package

    * Committing clang-format changes

    * Fixes an H5EA iterate issue

    * Fixes an issue in the H5FA iterator code

    * Further cleanup in bin/trace after macro removal

    * Iterator changes in H5EA and H5FA

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Various CMake changes (#679)

    * Committing clang-format changes

    * Several CMake updates:

    * Removes unused HDF5_ENABLE_HSIZET
    * Switches TEST_SHELL_SCRIPTS to ON
    * Sets SH_PROGRAM to bash instead of sh

    * Set default build type back to RelWithDebInfo

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Revert "Removes alternative function enter/leave macro scheme (#678)"

    This reverts commit edddb11b791adbdcaafed3ba718c95dd349a4e9a.

    * err_compat test cleanup (#681)

    * Committing clang-format changes

    * Cleans up err_compat test and output

    * Formatted source

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Sets the memory alloc sanity check option to disabled in autotools (#686)

    * Revert "Sets the memory alloc sanity check option to disabled in autotools (#686)"

    This reverts commit 652ffca58699388fff960c6a92c8ecfd1fc5d19b.

    (Only for release branch).

    * Removes alternative function enter/leave macro scheme (#678)

    * Committing clang-format changes

    * Converted BEGIN_FUNC, etc. macros to FUNC_ENTER

    * Rips out the BEGIN_FUNC, etc. macros

    * Removes 'end if', etc. comments from H5HL package

    * Committing clang-format changes

    * Fixes an H5EA iterate issue

    * Fixes an issue in the H5FA iterator code

    * Further cleanup in bin/trace after macro removal

    * Iterator changes in H5EA and H5FA

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Committing clang-format changes

    Co-authored-by: jhendersonHDF <[email protected]>
    Co-authored-by: Dana Robinson <[email protected]>
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: bmribler <[email protected]>
    Co-authored-by: Jan-Willem Blokland <[email protected]>
    Co-authored-by: Jan-Willem Blokland <[email protected]>
    Co-authored-by: Sean McBride <[email protected]>

commit 14794490ec522fbd3ac2faa6efa0920979490fbc
Author: Larry Knox <[email protected]>
Date:   Wed Jul 14 13:50:26 2021 -0500

    Update version to 1.10.8-2 after snapshot release of 1.10.8-1 (#838)

    * Revert addition of & to 2 parameters in DSetCreatPropList::setVirtual to
    maintain binary compatibility.

    * Fix H5Eget_auto2/H5Eauto_is_v2 to not clear error stack (#625)

    * Removes gratuitous (double)x.yF casts (#632)

    * Committing clang-format changes

    * Removes gratuitous (double)x.yF casts

    * Committing clang-format changes

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Cleans up a const warning left over from previous constification (#633)

    * Committing clang-format changes

    * Adds consts to a few global variables

    * Cleans up a const warning left over from previous constification

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Purges UFAIL from the library (#637)

    * Committing clang-format changes

    * Purges UFAIL from the library

    * H5HL_insert change requested in PR

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Bmr dev hdffv 11223 (#640)

    * Fixed HDFFV-11223 (CVE-2018-14460)

    Description
        - Added checks against buffer size to prevent segfault, in case of data
          corruption, for sdim->size and sdim->max.
        - Renamed data files in an existing test to shorten their length
          as agreed with other developers previously.
    Platforms tested:
        Linux/64 (jelly)

    * Committing clang-format changes

    * Updated for test files

    * Updated for HDFFV-11223

    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

    * Committing clang-format changes

    * Restore "e…
  • Loading branch information
9 people authored Jul 26, 2021
1 parent d97e989 commit 1aa2c34
Show file tree
Hide file tree
Showing 27 changed files with 169 additions and 237 deletions.
38 changes: 32 additions & 6 deletions bin/trace
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,33 @@ sub rewrite_func ($$$$$) {
# Compose the trace macro
$trace = "H5TRACE" . scalar(@arg_str) . "(\"$rettype\", \"";
$trace .= join("", @arg_str) . "\"";
my $len = 4 + length $trace; # Add 4, for indenting the line
for (@arg_name) {
# Wrap lines that will be longer than the limit, after ');' is added
if ($len + length >= ($max_trace_macro_line_len - 2)) {
$argtrace .= join("", @arg_str) . "\"";

# Add 4 for indenting the line
my $len = 4 + length($trace);

for my $i (0 .. $#arg_name) {
# Handle wrapping

# Be VERY careful here! clang-format and this script MUST agree
# on which lines get wrapped or there will be churn as each tries
# to undo the other's output.
#
# TWO cases must be handled:
# 1) The argument is that last one and ');' will be appended
# 2) The argument is NOT the last one and ',' will be appended
#
# NB: clang-format does NOT consider terminal newlines when
# counting columns for the ColumnLimit
#
# The extra '2' added after $len includes the ', ' that would be
# added BEFORE the argument.
#
my $adjust = ($i + 1 == scalar(@arg_str)) ? 2 : 1;
my $len_if_added = $len + 2 + length($arg_name[$i]) + $adjust;

# Wrap lines that will be longer than the limit
if ($len_if_added > $max_trace_macro_line_len) {
# Wrap line, with indention
$trace .= ",\n ";
$len = 13; # Set to 13, for indention
Expand All @@ -317,8 +340,11 @@ sub rewrite_func ($$$$$) {
}

# Append argument
$trace .= "$_";
$len += length; # Add length of appended argument name
$trace .= "$arg_name[$i]";
$argtrace .= ", $arg_name[$i]";

# Add length of appended argument name
$len += length($arg_name[$i]);
}

# Append final ');' for macro
Expand Down
18 changes: 0 additions & 18 deletions config/cmake/H5pubconf.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,9 @@
optimization operation */
#cmakedefine H5_HAVE_INSTRUMENTED_LIBRARY @H5_HAVE_INSTRUMENTED_LIBRARY@

/* Define to 1 if you have the <inttypes.h> header file. */
#cmakedefine H5_HAVE_INTTYPES_H @H5_HAVE_INTTYPES_H@

/* Define to 1 if you have the `ioctl' function. */
#cmakedefine H5_HAVE_IOCTL @H5_HAVE_IOCTL@

/* Define to 1 if you have the <io.h> header file. */
#cmakedefine H5_HAVE_IO_H @H5_HAVE_IO_H@

/* Define to 1 if you have the `crypto' library (-lcrypto). */
#cmakedefine H5_HAVE_LIBCRYPTO @H5_HAVE_LIBCRYPTO@

Expand Down Expand Up @@ -358,18 +352,9 @@
/* Define if `struct stat' has the `st_blocks' field */
#cmakedefine H5_HAVE_STAT_ST_BLOCKS @H5_HAVE_STAT_ST_BLOCKS@

/* Define to 1 if you have the <stdbool.h> header file. */
#cmakedefine H5_HAVE_STDBOOL_H @H5_HAVE_STDBOOL_H@

/* Define to 1 if you have the <stddef.h> header file. */
#cmakedefine H5_HAVE_STDDEF_H @H5_HAVE_STDDEF_H@

/* Define to 1 if you have the <stdint.h> header file. */
#cmakedefine H5_HAVE_STDINT_H @H5_HAVE_STDINT_H@

/* Define to 1 if you have the <stdint.h> header file for Cplusplus. */
#cmakedefine H5_HAVE_STDINT_H_CXX @H5_HAVE_STDINT_H_CXX@

/* Define to 1 if you have the <stdlib.h> header file. */
#cmakedefine H5_HAVE_STDLIB_H @H5_HAVE_STDLIB_H@

Expand Down Expand Up @@ -713,9 +698,6 @@
/* The size of `__int64', as computed by sizeof. */
#define H5_SIZEOF___INT64 @H5_SIZEOF___INT64@

/* Define to 1 if you have the ANSI C header files. */
#cmakedefine H5_STDC_HEADERS @H5_STDC_HEADERS@

/* Define if strict file format checks are enabled */
#cmakedefine H5_STRICT_FORMAT_CHECKS @H5_STRICT_FORMAT_CHECKS@

Expand Down
29 changes: 3 additions & 26 deletions config/cmake_ext_mod/ConfigureChecks.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -120,23 +120,13 @@ CHECK_INCLUDE_FILE_CONCAT ("features.h" ${HDF_PREFIX}_HAVE_FEATURES_H)
CHECK_INCLUDE_FILE_CONCAT ("dirent.h" ${HDF_PREFIX}_HAVE_DIRENT_H)
CHECK_INCLUDE_FILE_CONCAT ("setjmp.h" ${HDF_PREFIX}_HAVE_SETJMP_H)
CHECK_INCLUDE_FILE_CONCAT ("stddef.h" ${HDF_PREFIX}_HAVE_STDDEF_H)
CHECK_INCLUDE_FILE_CONCAT ("stdint.h" ${HDF_PREFIX}_HAVE_STDINT_H)
CHECK_INCLUDE_FILE_CONCAT ("unistd.h" ${HDF_PREFIX}_HAVE_UNISTD_H)

# Windows
CHECK_INCLUDE_FILE_CONCAT ("io.h" ${HDF_PREFIX}_HAVE_IO_H)
if (NOT CYGWIN)
CHECK_INCLUDE_FILE_CONCAT ("winsock2.h" ${HDF_PREFIX}_HAVE_WINSOCK2_H)
endif ()

if (CMAKE_SYSTEM_NAME MATCHES "OSF")
CHECK_INCLUDE_FILE_CONCAT ("sys/sysinfo.h" ${HDF_PREFIX}_HAVE_SYS_SYSINFO_H)
CHECK_INCLUDE_FILE_CONCAT ("sys/proc.h" ${HDF_PREFIX}_HAVE_SYS_PROC_H)
else ()
set (${HDF_PREFIX}_HAVE_SYS_SYSINFO_H "" CACHE INTERNAL "" FORCE)
set (${HDF_PREFIX}_HAVE_SYS_PROC_H "" CACHE INTERNAL "" FORCE)
endif ()

CHECK_INCLUDE_FILE_CONCAT ("globus/common.h" ${HDF_PREFIX}_HAVE_GLOBUS_COMMON_H)
CHECK_INCLUDE_FILE_CONCAT ("pdb.h" ${HDF_PREFIX}_HAVE_PDB_H)
CHECK_INCLUDE_FILE_CONCAT ("pthread.h" ${HDF_PREFIX}_HAVE_PTHREAD_H)
Expand All @@ -146,12 +136,9 @@ CHECK_INCLUDE_FILE_CONCAT ("strings.h" ${HDF_PREFIX}_HAVE_STRINGS_H)
CHECK_INCLUDE_FILE_CONCAT ("stdlib.h" ${HDF_PREFIX}_HAVE_STDLIB_H)
CHECK_INCLUDE_FILE_CONCAT ("memory.h" ${HDF_PREFIX}_HAVE_MEMORY_H)
CHECK_INCLUDE_FILE_CONCAT ("dlfcn.h" ${HDF_PREFIX}_HAVE_DLFCN_H)
CHECK_INCLUDE_FILE_CONCAT ("inttypes.h" ${HDF_PREFIX}_HAVE_INTTYPES_H)
CHECK_INCLUDE_FILE_CONCAT ("netinet/in.h" ${HDF_PREFIX}_HAVE_NETINET_IN_H)
CHECK_INCLUDE_FILE_CONCAT ("netdb.h" ${HDF_PREFIX}_HAVE_NETDB_H)
CHECK_INCLUDE_FILE_CONCAT ("arpa/inet.h" ${HDF_PREFIX}_HAVE_ARPA_INET_H)
# _Bool type support
CHECK_INCLUDE_FILE_CONCAT (stdbool.h ${HDF_PREFIX}_HAVE_STDBOOL_H)

## Check for non-standard extenstion quadmath.h

Expand Down Expand Up @@ -237,11 +224,6 @@ macro (HDF_FUNCTION_TEST OTHER_TEST)
endif ()
endmacro ()

#-----------------------------------------------------------------------------
# Check for these functions before the time headers are checked
#-----------------------------------------------------------------------------
HDF_FUNCTION_TEST (STDC_HEADERS)

#-----------------------------------------------------------------------------
# Check for large file support
#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -416,13 +398,9 @@ HDF_CHECK_TYPE_SIZE (time_t ${HDF_PREFIX}_SIZEOF_TIME_T)
# Extra C99 types
#-----------------------------------------------------------------------------

# _Bool type support
if (HAVE_STDBOOL_H)
set (CMAKE_EXTRA_INCLUDE_FILES stdbool.h)
HDF_CHECK_TYPE_SIZE (bool ${HDF_PREFIX}_SIZEOF_BOOL)
else ()
HDF_CHECK_TYPE_SIZE (_Bool ${HDF_PREFIX}_SIZEOF_BOOL)
endif ()
# Size of bool
set (CMAKE_EXTRA_INCLUDE_FILES stdbool.h)
HDF_CHECK_TYPE_SIZE (_Bool ${HDF_PREFIX}_SIZEOF_BOOL)

if (MINGW OR NOT WINDOWS)
#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -560,7 +538,6 @@ if (MINGW OR NOT WINDOWS)
foreach (other_test
HAVE_ATTRIBUTE
HAVE_C99_FUNC
# STDC_HEADERS
HAVE_FUNCTION
HAVE_C99_DESIGNATED_INITIALIZER
SYSTEM_SCOPE_THREADS
Expand Down
8 changes: 0 additions & 8 deletions config/cmake_ext_mod/HDFTests.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,6 @@ int main(void)
}
#endif

#ifdef STDC_HEADERS
#include <stdlib.h>
#include <stdarg.h>
#include <string.h>
#include <float.h>
int main() { return 0; }
#endif /* STDC_HEADERS */


#ifdef HAVE_ATTRIBUTE

Expand Down
11 changes: 0 additions & 11 deletions config/cmake_ext_mod/HDFUseCXX.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,6 @@ endif ()
include (CheckIncludeFileCXX)
include (TestForSTDNamespace)

# IF the c compiler found stdint, check the C++ as well. On some systems this
# file will be found by C but not C++, only do this test IF the C++ compiler
# has been initialized (e.g. the project also includes some c++)
if (${HDF_PREFIX}_HAVE_STDINT_H AND CMAKE_CXX_COMPILER_LOADED)
CHECK_INCLUDE_FILE_CXX ("stdint.h" ${HDF_PREFIX}_HAVE_STDINT_H_CXX)
if (NOT ${HDF_PREFIX}_HAVE_STDINT_H_CXX)
set (${HDF_PREFIX}_HAVE_STDINT_H "" CACHE INTERNAL "Have includes HAVE_STDINT_H")
set (USE_INCLUDES ${USE_INCLUDES} "stdint.h")
endif ()
endif ()

# For other CXX specific tests, use this MACRO.
macro (HDF_CXX_FUNCTION_TEST OTHER_TEST)
if (NOT DEFINED ${OTHER_TEST})
Expand Down
53 changes: 13 additions & 40 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -1224,8 +1224,6 @@ AC_CHECK_HEADERS([sys/resource.h sys/time.h unistd.h sys/ioctl.h sys/stat.h])
AC_CHECK_HEADERS([sys/socket.h sys/types.h sys/file.h])
AC_CHECK_HEADERS([stddef.h setjmp.h features.h])
AC_CHECK_HEADERS([dirent.h])
AC_CHECK_HEADERS([stdint.h], [C9x=yes])
AC_CHECK_HEADERS([stdbool.h])
AC_CHECK_HEADERS([netdb.h netinet/in.h arpa/inet.h])

## Darwin
Expand All @@ -1241,15 +1239,15 @@ esac
## Windows
case "`uname`" in
CYGWIN*)
AC_CHECK_HEADERS([io.h sys/timeb.h])
AC_CHECK_HEADERS([sys/timeb.h])
UNAME_CYGWIN="yes"
;;
MINGW*)
AC_CHECK_HEADERS([io.h winsock2.h sys/timeb.h])
AC_CHECK_HEADERS([winsock2.h sys/timeb.h])
AC_HAVE_LIBRARY([ws2_32])
;;
*)
AC_CHECK_HEADERS([io.h winsock2.h sys/timeb.h])
AC_CHECK_HEADERS([winsock2.h sys/timeb.h])
;;
esac

Expand Down Expand Up @@ -1340,16 +1338,15 @@ CFLAGS="$H5_CFLAGS $AM_CFLAGS $CFLAGS"
## Checkpoint the cache
AC_CACHE_SAVE

## Posix.1g types (C9x)
## Write the confdefs.h header for checking sizes
cat >>confdefs.h <<\EOF
#include <sys/types.h>
EOF

if test "X$C9x" = "Xyes"; then
cat >>confdefs.h <<\EOF
#include <stdbool.h>
#include <stdint.h>
#ifdef HAVE_UNISTD_H
#include <sys/types.h>
#endif
#include <time.h>
EOF
fi

AC_CHECK_SIZEOF( [int8_t])
AC_CHECK_SIZEOF( [uint8_t])
Expand Down Expand Up @@ -1379,34 +1376,12 @@ AC_CHECK_SIZEOF([uint_least64_t])
AC_CHECK_SIZEOF( [int_fast64_t])
AC_CHECK_SIZEOF( [uint_fast64_t])

AC_CHECK_SIZEOF([bool])
AC_CHECK_SIZEOF([off_t])
AC_CHECK_SIZEOF([ptrdiff_t])
AC_CHECK_SIZEOF([size_t])
AC_CHECK_SIZEOF([ssize_t])
AC_CHECK_SIZEOF([ptrdiff_t])

cat >>confdefs.h <<\EOF
#include <sys/types.h> /*for off_t definition*/
EOF
AC_CHECK_SIZEOF([off_t])

if test "X$C9x" = "Xyes"; then
cat >>confdefs.h <<\EOF
#ifdef HAVE_STDBOOL_H
#include <stdbool.h> /* for bool definition */
#else
#define bool _Bool
#endif
EOF
AC_CHECK_SIZEOF([bool])
fi

AC_CHECK_SIZEOF(time_t, [], [
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#ifdef HAVE_TIME_H
#include <time.h>
#endif
])
AC_CHECK_SIZEOF([time_t])

## Checkpoint the cache
AC_CACHE_SAVE
Expand Down Expand Up @@ -1911,10 +1886,8 @@ if test "X$THREADSAFE" = "Xyes"; then
AC_CACHE_VAL([hdf5_cv_system_scope_threads],
[AC_RUN_IFELSE(
[AC_LANG_PROGRAM([
#if STDC_HEADERS
#include <stdlib.h>
#include <pthread.h>
#endif
],[
pthread_attr_t attribute;
int ret;
Expand Down
43 changes: 43 additions & 0 deletions release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,49 @@ New Features

Library:
--------
- H5Gcreate1() now rejects size_hint parameters larger than UINT32_MAX

The size_hint value is ultimately stored in a uint32_t struct field,
so specifying a value larger than this on a 64-bit machine can cause
undefined behavior including crashing the system.

The documentation for this API call was also incorrect, stating that
passing a negative value would cause the library to use a default
value. Instead, passing a "negative" value actually passes a very large
value, which is probably not what the user intends and can cause
crashes on 64-bit systems.

The Doxygen documentation has been updated and passing values larger
than UINT32_MAX for size_hint will now produce a normal HDF5 error.

(DER - 2021/04/29, HDFFV-11241)


- H5Pset_fapl_log() no longer crashes when passed an invalid fapl ID

When passed an invalid fapl ID, H5Pset_fapl_log() would usually
segfault when attempting to free an uninitialized pointer in the error
handling code. This behavior is more common in release builds or
when the memory sanitization checks were not selected as a build
option.

The pointer is now correctly initialized and the API call now
produces a normal HDF5 error when fed an invalid fapl ID.

(DER - 2021/04/28, HDFFV-11240)

- Fixes a segfault when H5Pset_mdc_log_options() is called multiple times

The call incorrectly attempts to free an internal copy of the previous
log location string, which causes a segfault. This only happens
when the call is invoked multiple times on the same property list.
On the first call to a given fapl, the log location is set to NULL so
the segfault does not occur.

The string is now handled properly and the segfault no longer occurs.

(DER - 2021/04/27, HDFFV-11239)

- HSYS_GOTO_ERROR now emits the results of GetLastError() on Windows

HSYS_GOTO_ERROR is an internal macro that is used to produce error
Expand Down
7 changes: 5 additions & 2 deletions src/H5FDlog.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,12 +326,15 @@ H5Pset_fapl_log(hid_t fapl_id, const char *logfile, unsigned long long flags, si
FUNC_ENTER_API(FAIL)
H5TRACE4("e", "i*sULz", fapl_id, logfile, flags, buf_size);

/* Do this first, so that we don't try to free a wild pointer if
* H5P_object_verify() fails.
*/
HDmemset(&fa, 0, sizeof(H5FD_log_fapl_t));

/* Check arguments */
if (NULL == (plist = H5P_object_verify(fapl_id, H5P_FILE_ACCESS)))
HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a file access property list")

HDmemset(&fa, 0, sizeof(H5FD_log_fapl_t));

/* Duplicate the log file string
* A little wasteful, since this string will just be copied later, but
* passing it in as a pointer sets off a chain of impossible-to-resolve
Expand Down
12 changes: 12 additions & 0 deletions src/H5FDmpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1470,6 +1470,12 @@ H5FD_mpio_read(H5FD_t *_file, H5FD_mem_t H5_ATTR_UNUSED type, hid_t H5_ATTR_UNUS
if (bytes_read < 0 || bytes_read > io_size)
HGOTO_ERROR(H5E_IO, H5E_READERROR, FAIL, "file read failed")

#ifdef H5FDmpio_DEBUG
if (H5FD_mpio_debug_r_flag)
HDfprintf(stderr, "%s: (%d) mpi_off = %ld bytes_read = %lld\n", FUNC, file->mpi_rank, (long)mpi_off,
bytes_read);
#endif

/*
* This gives us zeroes beyond end of physical MPI file.
*/
Expand Down Expand Up @@ -1659,6 +1665,12 @@ H5FD_mpio_write(H5FD_t *_file, H5FD_mem_t type, hid_t H5_ATTR_UNUSED dxpl_id, ha
if (bytes_written != io_size)
HGOTO_ERROR(H5E_IO, H5E_WRITEERROR, FAIL, "file write failed")

#ifdef H5FDmpio_DEBUG
if (H5FD_mpio_debug_w_flag)
HDfprintf(stderr, "%s: (%d) mpi_off = %ld bytes_written = %lld\n", FUNC, file->mpi_rank,
(long)mpi_off, bytes_written);
#endif

/* Each process will keep track of its perceived EOF value locally, and
* ultimately we will reduce this value to the maximum amongst all
* processes, but until then keep the actual eof at HADDR_UNDEF just in
Expand Down
Loading

0 comments on commit 1aa2c34

Please sign in to comment.