Skip to content

Commit

Permalink
Skip some parallel tests for OpenMPI version 5.0.5 (#5151)
Browse files Browse the repository at this point in the history
An issue in the 5.0.5 release of OpenMPI causes some parallel
HDF5 tests to fail. The issue was resolved in the OpenMPI 5.0.6
release.
  • Loading branch information
jhendersonHDF authored Nov 27, 2024
1 parent 460e70c commit 090e604
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
6 changes: 6 additions & 0 deletions release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -559,6 +559,12 @@ Bug Fixes since HDF5-2.0.0 release

Testing
-------
- Added skipping of a few parallel tests for OpenMPI 5.0.5

An issue in OpenMPI 5.0.5 causes a few parallel HDF5 tests
(mpiodup, props, fapl_preserve) to fail. These tests are
now skipped for that release of OpenMPI. The issue has
been fixed in the 5.0.6 release of OpenMPI.


Platforms Tested
Expand Down
35 changes: 35 additions & 0 deletions testpar/testphdf5.c
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,19 @@ main(int argc, char **argv)
test_params.count = 0;

/* Tests are generally arranged from least to most complexity... */

/* Skip this test for OpenMPI version 5.0.5 since an issue was
* introduced in that release which causes this test to fail.
* The issue was fixed for the 5.0.6 release.
*/
#if defined(OPEN_MPI) && defined(OMPI_MAJOR_VERSION) && (OMPI_MAJOR_VERSION == 5) && \
defined(OMPI_MINOR_VERSION) && (OMPI_MINOR_VERSION == 0) && defined(OMPI_RELEASE_VERSION) && \
(OMPI_RELEASE_VERSION == 5)
AddTest("-mpiodup", test_fapl_mpio_dup, NULL, NULL, NULL, 0, "fapl_mpio duplicate");
#else
AddTest("mpiodup", test_fapl_mpio_dup, NULL, NULL, NULL, 0, "fapl_mpio duplicate");
#endif

AddTest("getdxplmpio", test_get_dxpl_mpio, NULL, NULL, &test_params, sizeof(test_params),
"dxpl_mpio get");

Expand All @@ -357,8 +369,19 @@ main(int argc, char **argv)
AddTest("page_buffer", test_page_buffer_access, NULL, NULL, &test_params, sizeof(test_params),
"page buffer usage in parallel");

/* Skip this test for OpenMPI version 5.0.5 since an issue was
* introduced in that release which causes this test to fail.
* The issue was fixed for the 5.0.6 release.
*/
#if defined(OPEN_MPI) && defined(OMPI_MAJOR_VERSION) && (OMPI_MAJOR_VERSION == 5) && \
defined(OMPI_MINOR_VERSION) && (OMPI_MINOR_VERSION == 0) && defined(OMPI_RELEASE_VERSION) && \
(OMPI_RELEASE_VERSION == 5)
AddTest("-props", test_file_properties, NULL, NULL, &test_params, sizeof(test_params),
"Coll Metadata file property settings");
#else
AddTest("props", test_file_properties, NULL, NULL, &test_params, sizeof(test_params),
"Coll Metadata file property settings");
#endif

AddTest("delete", test_delete, NULL, NULL, &test_params, sizeof(test_params), "MPI-IO VFD file delete");

Expand All @@ -367,8 +390,20 @@ main(int argc, char **argv)

AddTest("evictparassert", test_evict_on_close_parallel_unsupp, NULL, NULL, &test_params,
sizeof(test_params), "Evict on close in parallel failure");

/* Skip this test for OpenMPI version 5.0.5 since an issue was
* introduced in that release which causes this test to fail.
* The issue was fixed for the 5.0.6 release.
*/
#if defined(OPEN_MPI) && defined(OMPI_MAJOR_VERSION) && (OMPI_MAJOR_VERSION == 5) && \
defined(OMPI_MINOR_VERSION) && (OMPI_MINOR_VERSION == 0) && defined(OMPI_RELEASE_VERSION) && \
(OMPI_RELEASE_VERSION == 5)
AddTest("-fapl_preserve", test_fapl_preserve_hints, NULL, NULL, &test_params, sizeof(test_params),
"preserve MPI I/O hints after fapl closed");
#else
AddTest("fapl_preserve", test_fapl_preserve_hints, NULL, NULL, &test_params, sizeof(test_params),
"preserve MPI I/O hints after fapl closed");
#endif

AddTest("idsetw", dataset_writeInd, NULL, NULL, &test_params, sizeof(test_params),
"dataset independent write");
Expand Down

0 comments on commit 090e604

Please sign in to comment.