-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PC port feature support (Win32/Linux) #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but this PR is huge... I really do appreciate the PC port and new Linux/Windows drivers.
There also seems to be additions which are unrelated to the PC port... that makes this harder to evaluate (shell scripts, schedule commands, publish events??)
I hope this doesn't break anything and doesn't cause issues on the ESP32 side...
It would have better to split this over multiple, smaller PRs... I'll see what I can do to review this though.
These seem like additional features, not related specifically to the PC port enhancement:
|
I can move them to a separate PR (PRs?). Say the word and I'll do it 😃 |
84e68e5
to
55f39f0
Compare
The following commits have been reverted:
Hopefully that makes the PR a bit easier to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix disk access path separator on Linux
I think this breaks the path on Arduino
OK, we're testing this PR, most looks good. One issue encountered is that images on ESP32 don't seem to load anymore, which I think has to do with the path separator change. edit: it looks like the removal of |
I don't think it's possible. The change I introduced isn't even compiled on Arduino builds. It was previously set to backslash, which wouldn't even make sense on ESP32 as backslashes are almost exclusively used by Windows. Besides, my changes here are only related to jsonl loading, which doesn't change the image loading process. |
Re:
That is possible. I assumed that the test code was there for the unfinished PC port, I didn't realize that it actually gets compiled on ESP32 as well. The |
The LVGL filesystem driver is needed on all platforms. That check is/was there for testing if the lvgl filesystem driver was working, as |
Corrected - that should fix the issue on ESP32. |
Thanks 😃 |
This PR adds the following improvements to the "PC" build of openHASP:
config.json
supportvoid setup()/void loop()
entrypoints for PC and Arduino buildsconfig.json
config.json
"action"
tag for all controls%xyz%
values in commands specified in"action"
tag (optional, build-time-disabled by default)lv_drivers
PR: Update PC port features fvanroie/lv_drivers#1It is worth noting that MQTT parameters cannot be passed in the command line arguments now - it's configured in
config.json
, as usual on ESP32 devices.If desired, I can try to restore that possibility, although I doubt that anyone was using it "in production" - the PC port wasn't really ready for that, due to lack of
config.json
support.The PR also adds some code quality improvements:
HASP_TARGET_ARDUINO
,HASP_TARGET_PC
macros instead ofdefined(WINDOWS) || defined(POSIX)
_chip_model
,_core_version
memcpy()
auto
) type instead ofuseconds_t
to fix building on Alpine Linux (musl libc)EDIT:
I've tested all these changes on
windows_sdl_64bits
,windows_gdi_64bits
,linux_sdl_64bits
andlinux_fbdev_64bits
. I haven't tested on ESP32, since I don't have a working setup at hand. Even though I haven't changed nearly anything in the ESP32 implementation, testing on actual hardware would be appreciated.