re-enable idle scripts #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanroie
requested changes
Jan 27, 2024
|
Done |
fvanroie
approved these changes
Jan 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #618
The idle scripts were inoperative since a recent commit.
Not sure if what I claim is true, but this is my interpretation: Since:
dispatch_idle_state()seems to be called also when a state situation is requested (dispatch_current_state())dispatch_idle()seems to be called only upon startuphasp_set_sleep_state()seems to be deprecatedand we want the scripts to be called only when the state changes, I decided to put the scripts directly in the function that detects the changes:
hasp_update_sleep_state()