Make MQTT work with Ethernet #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f networkStart & networkStop
Merged
|
Don't forget to test if the online/offline scripts still work in both wifi and Ethetnet mode... |
|
Yes online/offline scripts work in Ethernet. This pull request make no changes to anything other than the ethernet code, so WiFi will have the same functionality it had before. |
|
Thanks Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Called the new functions network_connected() and network_disconnected() instead of directly calling networkStart() and networkStop().
This accounts for the change to networkEvery5Seconds() which no longer directly checks for the ethernet connection status.
So now MQTT will connect as it should