Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Nix packaging #93

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Refactor Nix packaging #93

merged 1 commit into from
Jan 3, 2025

Conversation

spitulax
Copy link
Contributor

@spitulax spitulax commented Jan 2, 2025

Changes:

  • The Rust toolchain is now obtained from rust-overlay
  • Added devShell
  • Moved Nix related files into nix/
  • Formatted Nix files

@H3rmt
Copy link
Owner

H3rmt commented Jan 2, 2025

Can you guarantee that this wont break any existing installs for nix users?

@H3rmt
Copy link
Owner

H3rmt commented Jan 2, 2025

Could you load the title, description, etc. from the toml instead of hardcoding them

@spitulax
Copy link
Contributor Author

spitulax commented Jan 3, 2025

Could you load the title, description, etc. from the toml instead of hardcoding them

See NixOS/nixpkgs#277994 on why it's a bad practice.

@spitulax
Copy link
Contributor Author

spitulax commented Jan 3, 2025

Can you guarantee that this wont break any existing installs for nix users?

If a user just use the package, for example inputs.hyprswitch.packages.x86_64-linux.hyprswitch or inputs.hyprswitch.packages.x86_64-linux.default it should be fine. I didn't remove anything from the flake outputs or any of meta attributes from the package. Remind me though if you realise something stopped working.

@H3rmt H3rmt merged commit b9786e9 into H3rmt:main Jan 3, 2025
@spitulax spitulax deleted the nix branch January 3, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants