Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: rename shortcut module and improve docstring/type hints consistency #543

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Sep 2, 2024

No description provided.

@github-actions github-actions bot added jobs Scenarios and jobs quality Tests, project resiliency, etc. labels Sep 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (f67df6d) to head (cb77ca9).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...deployment_toolbelt/shortcuts/shortcuts_handler.py 46.15% 3 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   71.14%   71.12%   -0.02%     
==========================================
  Files          47       46       -1     
  Lines        3091     3089       -2     
  Branches      666      665       -1     
==========================================
- Hits         2199     2197       -2     
+ Misses        700      699       -1     
- Partials      192      193       +1     
Flag Coverage Δ
unittests 70.54% <56.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/constants.py 85.71% <100.00%> (+0.32%) ⬆️
qgis_deployment_toolbelt/jobs/job_shortcuts.py 55.88% <100.00%> (ø)
...deployment_toolbelt/shortcuts/shortcuts_handler.py 65.15% <46.15%> (ø)

@Guts Guts enabled auto-merge September 2, 2024 14:18
@Guts Guts self-assigned this Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

@Guts Guts removed the jobs Scenarios and jobs label Sep 2, 2024
@Guts Guts merged commit 92a8472 into main Sep 2, 2024
25 checks passed
@Guts Guts deleted the refacto/rename-shortcut-module branch September 2, 2024 14:20
@Guts Guts added this to the 0.34.5 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants