Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto(cleanup): fix some type hints and relative imports #540

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Aug 30, 2024

No description provided.

@Guts Guts self-assigned this Aug 30, 2024
@Guts Guts added enhancement New feature or request quality Tests, project resiliency, etc. and removed enhancement New feature or request labels Aug 30, 2024
@Guts Guts enabled auto-merge August 30, 2024 15:15
Copy link

sonarcloud bot commented Aug 30, 2024

@Guts Guts disabled auto-merge August 30, 2024 15:19
@Guts Guts enabled auto-merge (squash) August 30, 2024 15:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.08%. Comparing base (9c71157) to head (8706fcb).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/journalizer.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   71.10%   71.08%   -0.03%     
==========================================
  Files          49       47       -2     
  Lines        3084     3081       -3     
  Branches      664      664              
==========================================
- Hits         2193     2190       -3     
  Misses        700      700              
  Partials      191      191              
Flag Coverage Δ
unittests 70.46% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/cli.py 80.35% <ø> (ø)
qgis_deployment_toolbelt/utils/journalizer.py 66.21% <50.00%> (ø)

@Guts Guts merged commit 240d9f2 into main Aug 30, 2024
25 checks passed
@Guts Guts deleted the refacto/minor-cleanup branch August 30, 2024 15:21
@Guts Guts added this to the 0.35.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants