Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(integration): support social cards for blog plugin posts #326

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Oct 23, 2024

This PR improves the Material Social Cards plugin integration by adding support for social cards generated for Material Blog plugin posts (https://squidfunk.github.io/mkdocs-material/plugins/blog/).

@Guts Guts self-assigned this Oct 23, 2024
@github-actions github-actions bot added enhancement New feature or request quality Tests, project resiliency, etc. labels Oct 23, 2024
@Guts Guts force-pushed the feature/support-material-blog branch from a07b216 to e6da720 Compare October 23, 2024 14:04
Copy link

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (4179aaf) to head (8bb75c5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...lugin/integrations/theme_material_social_plugin.py 54.54% 11 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   80.72%   79.57%   -1.15%     
==========================================
  Files           9        9              
  Lines         638      666      +28     
  Branches      111      117       +6     
==========================================
+ Hits          515      530      +15     
- Misses         85       94       +9     
- Partials       38       42       +4     
Flag Coverage Δ
unittests 79.57% <54.54%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/integrations/theme_material_social_plugin.py 72.36% <54.54%> (-4.25%) ⬇️

@Guts Guts merged commit bffc8ba into main Oct 24, 2024
11 checks passed
@Guts Guts deleted the feature/support-material-blog branch October 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant