Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make match_path OS agnostic #323

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Make match_path OS agnostic #323

merged 1 commit into from
Sep 5, 2024

Conversation

mvelikikh
Copy link
Contributor

page.file.src_path on Windows contains backslashes resulting in an empty RSS feed if match_path contains a forward slash. This commit replaces src_path with src_uri which provides an OS independent path with forward slashes '/'.

fixes #321

`page.file.src_path` on Windows contains backslashes resulting in an empty RSS feed if `match_path` contains a forward slash. This commit replaces `src_path` with `src_uri` which provides an OS independent path with forward slashes '/'.

Signed-off-by: Mikhail Velikikh <[email protected]>
Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (a168516) to head (020d441).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files          10       10           
  Lines         653      653           
  Branches      134      134           
=======================================
  Hits          527      527           
  Misses         86       86           
  Partials       40       40           
Flag Coverage Δ
unittests 80.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
mkdocs_rss_plugin/plugin.py 90.51% <100.00%> (ø)

@Guts
Copy link
Owner

Guts commented Sep 5, 2024

Thanks @mvelikikh and welcome to the contributors :).

@Guts Guts merged commit a44922c into Guts:main Sep 5, 2024
9 checks passed
@Guts Guts added the bug Something isn't working label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match_path is not OS agnostic
2 participants