-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow per-page description customization #310
Conversation
Hi @meysam81 , Thanks for your PR. I'm still thinking if it's worth it because it adds a certain complexity from an operational point of view, with nesting levels that are difficult to track and debug. Remarks:
|
I will add the docs and the tests later this week. Thanks for the feedback. |
Please have another look and let me know if there's any other change required. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 80.64% 80.70% +0.05%
==========================================
Files 10 10
Lines 651 653 +2
Branches 133 134 +1
==========================================
+ Hits 525 527 +2
Misses 86 86
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀!
Thanks a lot for your contribution!
Released as part of https://github.com/Guts/mkdocs-rss-plugin/releases/tag/1.15.0 |
Hello @Guts
Thanks for the awesome project.
I use this plugin heavily in my SRE blog.
I figured it would be nice to allow per page customization of the
description
field, cause at the moment, there's not a lot one can do when the description before<!-- more -->
is short and extra detail is desired.With this change, you can have separate contents for RSS description and your typical content.
An example taken from the Material for Mkdocs Social Cards:
This idea, I reckon, can easily be extended for other similar use-cases:
page.meta.image
with relative path #197