Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): do not raise error for bad date_from_meta.default_time value and fallback to default #300

Merged

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 23, 2024

Closes #290

@Guts Guts self-assigned this Jun 23, 2024
Copy link

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (09e4ce4) to head (38c477f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   80.65%   80.45%   -0.20%     
==========================================
  Files           9        9              
  Lines         615      614       -1     
  Branches      128      128              
==========================================
- Hits          496      494       -2     
- Misses         82       83       +1     
  Partials       37       37              
Flag Coverage Δ
unittests 80.45% <25.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mkdocs_rss_plugin/config.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/plugin.py 89.92% <0.00%> (-0.78%) ⬇️

@Guts Guts added the enhancement New feature or request label Jun 23, 2024
@Guts Guts merged commit 85ef616 into main Jun 23, 2024
9 checks passed
@Guts Guts deleted the change/do-not-raise-error-for-bad-date_from_meta.default_time branch June 23, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: strptime() argument 1 must be str, not datetime.datetime
1 participant