Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: set minimal python version to 3.10 #286

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jun 10, 2024

Since some advanced types operations introduced in mkdocs>=1.5 are not entirely supported by Python 3.8 and 3.9, let's switch to 3.10 as minimal version:

Logs with failing error in #285 (https://github.com/Guts/mkdocs-rss-plugin/actions/runs/9450849461/job/26030426819?pr=285):

FAILED tests/test_build.py::TestBuildRss::test_simple_build_custom_output_basename - TypeError: Subscripted generics cannot be used with class and instance checks

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/plugins.py:96: in load_config
    return self.config.validate()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:231: in validate
    run_failed, run_warnings = self._validate()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:188: in _validate
    self[key] = config_option.validate(value)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:55: in validate
    return self.run_validation(value)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:110: in run_validation
    failed, warnings = config.validate()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:231: in validate
    run_failed, run_warnings = self._validate()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/base.py:188: in _validate
    self[key] = config_option.validate(value)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:186: in validate
    return self.run_validation(value)
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/mkdocs/config/config_options.py:344: in run_validation
    if not isinstance(value, self._type):
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/typing.py:769: in __instancecheck__
    return self.__subclasscheck__(type(obj))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

@github-actions github-actions bot added ci-cd Everything related to continuous integration and deployment tooling Development tooling quality Tests, project resiliency, etc. packaging labels Jun 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (1f4f792) to head (8ec6164).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   85.04%   83.12%   -1.93%     
==========================================
  Files          10       10              
  Lines         555      551       -4     
  Branches      117      116       -1     
==========================================
- Hits          472      458      -14     
- Misses         53       64      +11     
+ Partials       30       29       -1     
Flag Coverage Δ
unittests 83.12% <100.00%> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lugin/integrations/theme_material_social_plugin.py 96.87% <ø> (-0.05%) ⬇️
mkdocs_rss_plugin/models.py 100.00% <100.00%> (ø)
mkdocs_rss_plugin/plugin.py 94.02% <100.00%> (-0.05%) ⬇️
mkdocs_rss_plugin/util.py 75.00% <100.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

@Guts Guts merged commit 3b8337e into main Jun 10, 2024
9 checks passed
@Guts Guts deleted the chore/set-minimal-python-version branch June 10, 2024 15:22
@Guts Guts added enhancement New feature or request and removed ci-cd Everything related to continuous integration and deployment tooling Development tooling packaging labels Jun 10, 2024
Guts added a commit that referenced this pull request Oct 23, 2024
Since:

- Python 3.8 reached its end of life on 2024-10-07
- Python 3.13 has been released on 2024-10-07


See: https://devguide.python.org/versions/


Related to: #304 #286 #288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant