-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs for abstract_delimiter #202
Conversation
Here're the corresponding implementation (to help the maintainer review). mkdocs-rss-plugin/mkdocs_rss_plugin/config.py Lines 16 to 20 in ae2459c
mkdocs-rss-plugin/mkdocs_rss_plugin/util.py Lines 446 to 459 in ae2459c
(↑ The following mkdocs-rss-plugin/mkdocs_rss_plugin/util.py Lines 479 to 489 in ae2459c
By the way, |
Hi @craigbox , Thanks for reporting. I would prefer that the code works as expected and documented, instead of changing the documentation. @craigbox in the meantime can you rebase on origin/main and try again please? |
Rebased and pushed. (The spelling of "delimiter" has already been fixed.) |
Signed-off-by: Craig Box <[email protected]>
Patches sent by mail by @tiosgz. Applied with `git am`. It's my very first time in this kind of [git email workflow](https://git-send-email.io/). Pfiu !. Command used: ```sh git am --3way --ignore-space-change v2-0001-fix-retrieving-article-description.patch git am --3way --ignore-space-change v2-0002-docs-configuration-fix-update-abstract_-chars_cou.patch git am --3way --ignore-space-change v2-0003-tests-add-test-cases-for-abstract_delimiter.patch ``` Supersedes #202 cc @craigbox @YDX-2147483647
I close here since #268 fixed the logic behind. |
The copy and paste from
abstract_chars_count
didn't matchabstract_delimiter
.If you tried
-1
:""
works well.