-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add option to set default timezone #142
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 81.21% 81.69% +0.48%
==========================================
Files 5 7 +2
Lines 330 366 +36
Branches 72 80 +8
==========================================
+ Hits 268 299 +31
- Misses 40 42 +2
- Partials 22 25 +3
|
Awesome, thanks for implementing! Looking forward to the next release (no hurry) 😀 |
Thanks for testing and feeding back. I wanted to complete the related documentation before releasing. It leads me to think about a What do you think @squidfunk? |
Got time to implement it in #145 |
Shouldn't that be covered by UTC? The idea was that if you parse the date, it should default to |
It's defined before to set the timezone (custom or UTC by default), so the time is just added to a simple date. Example: Config: plugins:
- rss:
date_from_meta:
as_creation: "date"
as_update: false
datetime_format: "%Y-%m-%d"
default_time: "22:00" Page meta: ---
title: "This page title is a perfect clickbait!"
authors:
- guts
date: 2020-10-22
--- Output: <pubDate>Thu, 22 Oct 2020 22:00:00 +0000</pubDate> Am I missing something? |
Okay, I may have confused something here. My problem was that when the date is left out, the time was shifted by the timezone offset. Since this is fixed now, you can view my comment as resolved. Personally, I don't see much use for a |
Example:
Defaults to UTC.
Closes #133