Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error when plugin disabled #107

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fixes error when plugin disabled #107

merged 1 commit into from
Feb 8, 2022

Conversation

dcode
Copy link
Contributor

@dcode dcode commented Feb 7, 2022

  • Returns from all hooks if plugin is disabled
  • Adds test case that demonstrates error before fix is applied
  • Adds test mkdocs.yml config in fixtures dir
  • ignore local environments when using direnv

Closes: #104

- Returns from all hooks if plugin is disabled
- Adds test case that demonstrates error before fix is applied
- Adds test mkdocs.yml config in fixtures dir
- ignore local environments when using direnv

Closes: Guts#104
@Guts Guts self-assigned this Feb 8, 2022
@Guts Guts added bug Something isn't working enhancement New feature or request labels Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #107 (c5213a3) into main (399de0d) will increase coverage by 1.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   67.17%   68.18%   +1.00%     
==========================================
  Files           5        5              
  Lines         326      330       +4     
  Branches       74       76       +2     
==========================================
+ Hits          219      225       +6     
+ Misses         77       76       -1     
+ Partials       30       29       -1     
Impacted Files Coverage Δ
mkdocs_rss_plugin/plugin.py 79.41% <100.00%> (+2.88%) ⬆️

@Guts
Copy link
Owner

Guts commented Feb 8, 2022

Thanks a lot for your contribution!
LGTM

@Guts Guts merged commit 7d5e1e4 into Guts:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using "enabled: false" together with "match_path"
2 participants