-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support defining a mapping between author identifier and the author in the feed #250
Comments
Hi @stefansli Sorry for the delay, I work on this side-project from time to time, mainly when I have free time to develop, review, get paid for or have a particular need. Well, I'm actively working on a better integration with the blog plugin from @squidfunk Material framework for Mkdocs. My goal is to retrieve the author's name from the I know it does not fully cover your needs, especially the full RSS compliance (author = "Firstname NAME [email protected]") as already spotted in other issues, but I think it's a good first step. I'm not willing to add another config file specific to this plugin alongside the others. With the 1.17, to include authors emails, you'll be able to extend the The other way, more aligned with the general plugin purpose, would be to use the git log (#37) which comes generally with both names and emails. But it's a bit more tricky since we would have to manage the "match" between authors names and git log and maybe uselss since we should rely on plugins which already do this kind of jobs. |
@stefansli mentioned integrations are packaged with the 1.17: https://github.com/Guts/mkdocs-rss-plugin/releases/tag/1.17.0. I let you try and give your feedback here. |
Hi @Guts, I'll try to test as soon as possible and will give feedback. Hopefully this is before the end of the week. |
Hello @stefansli, No hurries, as you may have noticed I'm not really in a rush on this project ;). |
Hi @Guts, I just tried this and I general it's working. However the author is generated as |
…343) Related to: #250 See: https://validator.w3.org/feed/docs/error/InvalidContact.html Before: ```xml <author>John Doe ([email protected])</author> ``` After: ```xml <author>[email protected] (John Doe)</author> ``` cc @stefansli
Thanks @stefansli for following up.
Sure, I was a bit confused with different format. Fixed in 1.17.1.
When you say in the past, you mean recently? if so, I can consider adding a backward compatibility but since it's not a big deal to update Material for Mkdocs, especially for the last year (mainly bug fixes and enhancements, no breaking changes), I think it's not necessary. If you are happy with the latest version, feel free to close here :). |
The RSS standard specifies the author should be
[email protected] (John Doe)
. In the documents I'd like to use a username, for example the github username, as author. Would it be possible to implement a mapping between usernames and RSS authors?I'm thinking aboud a new config setting and a yaml file that maps the authors to RSS Name + Email definitions.
Alternatively one could implement
rss_author
andrss_authors
metadata.Background information:
I'm using the mkdocs-material theme with the blog plugin. The blog plugin can also render pages for authors. With the current setup, specifying a RSS conform author, the URL to the authors page looks quite ugly (containing %40 for the
@
and several spaces).Do you thinkt that's a good idea? Then I'd start with an implememtation and open a pull request.
The text was updated successfully, but these errors were encountered: