Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix tracing with graphql-ruby interpreter #52

Closed
wants to merge 1 commit into from

Conversation

jturkel
Copy link
Contributor

@jturkel jturkel commented Feb 3, 2020

Attempting to use ApolloFederation::Tracing with the graphql-ruby interpreter runtime resulted in exceptions like this:

KeyError: key not found: :context
# ./lib/apollo-federation/tracing/tracer.rb:106:in `fetch'
# ./lib/apollo-federation/tracing/tracer.rb:106:in `execute_field'
# ./lib/apollo-federation/tracing/tracer.rb:50:in `trace'
# ...

This PR fixes that issue and resolves another issue with the field_type being set incorrectly in metrics recorded using the interpreter. The spec/apollo-federation/tracing_spec.rb diff looks kind of scary but I just moved all of the testing into a shared example group that could be reused with the legacy runtime and the interpreter runtime.

@jturkel jturkel changed the title Fix tracing with graphql-ruby interpreter fix: Fix tracing with graphql-ruby interpreter Feb 3, 2020
@srgoldman
Copy link

@noaelad any chance of getting this into an official release soon?

@jturkel
Copy link
Contributor Author

jturkel commented Mar 31, 2020

Looks like this ended up being fixed in #59.

@jturkel jturkel closed this Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants