fix: Make the tracer work with the new interpreter runtime #59
Conversation
daemonsy
changed the title
| let(:base_schema) do | ||
| Class.new(GraphQL::Schema) do | ||
| use ApolloFederation::Tracing | ||
| RSpec.shared_examples 'a basic tracer' do |
There was a problem hiding this comment.
Large diff to the spec mostly due to indentation and an edit on one of the line. I'll highlight where the changes are.
Right on this line, I wrapped the whole test into a shared example so we can run them with the interpreter on
| error: [{ | ||
| message: "Can't continue with this query", | ||
| location: [{ line: 1, column: 15 }], | ||
| json: %({"message":"Can't continue with this query","locations":[{"line":1,"column":15}],"path":["items",1,"name"]}), |
There was a problem hiding this comment.
I removed some whitespace here. Previously it had some whitespace added into it.
| field_type = data.fetch(:field).type.unwrap.graphql_name | ||
| field = data.fetch(:field) | ||
| field_name = field.graphql_name | ||
| field_type = field.type.unwrap.graphql_name |
There was a problem hiding this comment.
Good call to write a spec @grxy . This has always been broken by the test caught it. The graphql_name of the type doesn't include whether it's nullable, hence the need to check the field
| if data.include?(:context) | ||
| path = context.path | ||
| field_name = context.field.graphql_name | ||
| field_type = context.field.type.to_s | ||
| parent_type = context.parent_type.graphql_name | ||
| else # legacy runtime | ||
| else # interpreter runtime |
There was a problem hiding this comment.
I believe we got the legacy and new interpreter the wrong way round. I get into this branch
|
Hey @noaelad 👋 this is a small fix before we can switch our own stuff to use the new interpreter. |
| field_type = data.fetch(:field).type.unwrap.graphql_name | ||
| field = data.fetch(:field) | ||
| field_name = field.graphql_name | ||
| field_type = field.type.to_type_signature |
There was a problem hiding this comment.
This seems like it's what we want. The other hacky way was leaky
daemonsy
changed the title
## [1.0.3](v1.0.2...v1.0.3) (2020-03-25) ### Bug Fixes * Make the tracer work with the new interpreter runtime ([#59](#59)) ([de4caf0](de4caf0))
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What's up?
Context can be on the query on passed directly as denoted by this statement. By without passing a second argument to
fetch, it raises so we never get to thedata.fetch(:query).contextbranch.