Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme about react-redux #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stropho
Copy link

@stropho stropho commented Aug 27, 2021

As explained in the README file, there is an issue with react-redux@6.
This issue is explained in more detail in reduxjs/react-redux#1126 where a codesandbox is also provided. Based on that codesandbox it seems that the issue is resolved in version 7 (you try changing the version in the codesnadbox)

@GuillaumeCisco
Copy link
Owner

I have an issue making your codesandbox working well.
I get the error:

Cannot read property 'count' of undefined

I will give it a try with the version 7 of react-redux, thanks!

@stropho
Copy link
Author

stropho commented Aug 30, 2021

Yup, as described in the linked issue there is another codesandbox ( https://codesandbox.io/s/yvw1vmnkrv ) with the same code - the only change is that it uses react-redux@5
v5 - ok
v6 - fails
v7 - ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants