PHPORM-101 Allow empty insert batch for consistency with Eloquent SQL

GromNaN · Oct 18, 2023 · 111d8aa · 111d8aa
1 parent 56a7233
commit 111d8aa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/Query/Builder.php b/src/Query/Builder.php
@@ -613,6 +613,11 @@ public function whereBetween($column, iterable $values, $boolean = 'and', $not =
     /** @inheritdoc */
     public function insert(array $values)
     {
+        // Allow empty insert batch for consistency with Eloquent SQL
+        if ($values === []) {
+            return true;
+        }
+
         // Since every insert gets treated like a batch insert, we will have to detect
         // if the user is inserting a single document or an array of documents.
         $batch = true;

diff --git a/tests/ModelTest.php b/tests/ModelTest.php
@@ -225,6 +225,12 @@ public function testFind(): void
         $this->assertEquals(35, $check->age);
     }
 
+    public function testInsertEmpty(): void
+    {
+        $success = User::insert([]);
+        $this->assertTrue($success);
+    }
+
     public function testGet(): void
     {
         User::insert([