Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicate_Momi_2023 #142

Merged
merged 3 commits into from
Jan 22, 2024
Merged

replicate_Momi_2023 #142

merged 3 commits into from
Jan 22, 2024

Conversation

Davi1990
Copy link
Collaborator

I added the example for replicating Momi et al., eLife 2023

@JohnGriffiths
Copy link
Collaborator

@Davi1990 I checked this and it runs ok, example is good.

I am good to approve merge of this, but pls do two more small things first:

  1. You need to add reference to the new example in the sphinx index so that it shows up in the website

specifically, add the line

auto_examples/eg006r__replicate_Momi2023

to this file

  1. Please add a little more description of what's going on the example and the results in the nice fig that is plotted

commit and push these two this to your branch and it will show up in this PR

Please run the make html sphinx build test locally / in codespaces and check the results before finalizing and pushing

Good work!

@Davi1990 Davi1990 merged commit 2d83324 into GriffithsLab:dev Jan 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants