Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[next]: Enable GPU tests on GTIR DaCe backend #1741

Merged
merged 13 commits into from
Nov 19, 2024

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Nov 18, 2024

DaCe v1.0.0 allows to enable GPU tests on the GTIR backend.

An issue was found in test_double_use_scalar. The dace gpu transformations have a bug that produces invalid code for SDFGs containing scalar expressions outside the field operator. A workaround is to run the simplify pass in order to bring the SDFG to a canonical form.

The changes in test code (test_execution.py) are pure cleanup.

@edopao edopao marked this pull request as ready for review November 18, 2024 15:56
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edopao edopao merged commit 9dbc884 into GridTools:main Nov 19, 2024
31 checks passed
@edopao edopao deleted the dace-v1.0-gpu branch November 19, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants