feat[next]: GTIR embedded and GTFN temporaries with new lowering #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p' into gtir_fuse_as_fieldop
tehrengruber
added a commit
that referenced
this pull request
Nov 11, 2024
#1648 exposed a compilation problem with nvcc which has been fixed in GridTools/gridtools#1811 included in gridtools 2.3.7.
edopao
reviewed
Nov 14, 2024
edopao
reviewed
Nov 14, 2024
edopao
reviewed
Nov 14, 2024
tehrengruber
added a commit
to tehrengruber/gt4py
that referenced
this pull request
Nov 14, 2024
tehrengruber
added a commit
that referenced
this pull request
Nov 14, 2024
tehrengruber
force-pushed
the
gtir_temporaries
branch
from
6befcdb to
262ffdd
Compare
havogt
requested changes
Nov 15, 2024
tests/next_tests/integration_tests/feature_tests/ffront_tests/test_scalar_if.py
Outdated
Show resolved
Hide resolved
tests/next_tests/integration_tests/feature_tests/iterator_tests/test_scan.py
Outdated
Show resolved
Hide resolved
...s/next_tests/integration_tests/multi_feature_tests/iterator_tests/test_vertical_advection.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new lowering for GTIR embedded, and GTFN. Only the dace iterator backend continues to use the old lowering.
Changes:
gt4py.next.backend.LEGACY_TRANSFORMS. Variable can be removed in a cleanup PR.apply_common_transformsin pass_manager_legacy.py. Just a straight copy of the old function. No need to review, this is just to avoid deleting until gtir based dace backend is ready.symbolic_sizesparam. Was in temporary extraction, is now part of the domain inference. In preparation of icon-exclaim tests