Small fixes to FOAST -> ITIR lowering #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix literal dtype used for unary expressions - Use `maximum` and `minimum` for `max_over`, `min_over` - User proper initial values for `max_over`, `min_over` on other dtypes than `float64`
havogt
approved these changes
Mar 6, 2023
havogt
added a commit
to C2SM/icon4py
that referenced
this pull request
Mar 7, 2023
This bug was exposed by a fix in the GT4Py lowering GridTools/gt4py#1196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some fixes for minor bugs I found while working on the temporaries.
maximumandminimumformax_over,min_overmax_over,min_overon other dtypes thanfloat64