Introduce ldg_ptr to Enable __ldg in Data Stores and simple_ptr_holder #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch perftest |
This was referenced Aug 14, 2024
|
Hi there, this is jenkins continuous integration... |
|
launch jenkins |
lukasm91
reviewed
Aug 19, 2024
|
|
||
| template <class T> | ||
| GT_FUNCTION constexpr T &&as_ldg_ptr(T &&value) { | ||
| return std::forward<T>(value); |
There was a problem hiding this comment.
Not sure I like this fallback. Doesn't it mean that if you wrap any pointer ad "ldg" pointer, which is not "ldg"-capable, it will silently do that. If this is the intent, then at least I don't like the naming.
There was a problem hiding this comment.
It doesn’t wrap anything, it just passes unsupported types through as is. We just call this function wherever we would like to use LDG when available. The name might be improvable though, so let me know if you have a better one …
|
launch jenkins |
havogt
reviewed
Aug 26, 2024
|
launch jenkins |
havogt
reviewed
Aug 26, 2024
|
launch perftest |
|
launch perftest |
|
launch jenkins |
|
launch perftest |
1 similar comment
|
launch perftest |
havogt
pushed a commit
that referenced
this pull request
Sep 30, 2024
#1802) Enables LDG loads for data stores with const data type and for neighbor tables. Shows performance improvements of up to 12% using NVCC and SID composites or dim2tuple on smaller domains. Using Clang, up to 70% performance improvements can be observed in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables LDG loads for data stores with const data type and for neighbor tables. Shows performance improvements of up to 12% using NVCC and SID composites or dim2tuple on smaller domains. Using Clang, up to 70% performance improvements can be observed in these cases.