Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang warning with __builtin_assume #1788

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Fix Clang warning with __builtin_assume #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
744e2ba
Fix warning regarding side-effects with Clang
iomaganaris Jun 18, 2024
f15a0a3
Use pure attribute instead of const
iomaganaris Jun 18, 2024
02663d7
Remove GT_PURE_FUNCTION for C++11 attribute gnu::pure based on @fthal…
iomaganaris Jun 19, 2024
72619c8
Updated performance references
fthaler Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/gridtools/fn/unstructured.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ namespace gridtools::fn {
int m_index;
};

/// gnu::pure attribute is necessary to enable __builtin_assume() optimization with Clang
template <class Tag, class Ptr, class Strides, class Domain>
GT_FUNCTION constexpr bool can_deref(iterator<Tag, Ptr, Strides, Domain> const &it) {
[[gnu::pure]] GT_FUNCTION constexpr bool can_deref(iterator<Tag, Ptr, Strides, Domain> const &it) {
return it.m_index != -1;
}

Expand Down
Loading
Loading