WIP: workarounds and disabled tests for cuda 12.4 #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Mar 13, 2024
| @@ -17,6 +17,6 @@ gridtools_add_icosahedral_test(stencil_on_edges SOURCES stencil_on_edges.cpp) | |||
| gridtools_add_icosahedral_test(stencil_fused SOURCES stencil_fused.cpp) | |||
| gridtools_add_icosahedral_test(stencil_on_neighedge_of_cells SOURCES stencil_on_neighedge_of_cells.cpp) | |||
| gridtools_add_icosahedral_test(stencil_on_vertices SOURCES stencil_on_vertices.cpp) | |||
| gridtools_add_icosahedral_test(curl SOURCES curl.cpp) | |||
| # gridtools_add_icosahedral_test(curl SOURCES curl.cpp) | |||
There was a problem hiding this comment.
this breaks in cicc phase
havogt
commented
Mar 13, 2024
| // enables workaround for CTAD/constexpr issues in CUDA 12.1, 12.2, 12.3 (https://github.com/GridTools/gridtools/issues/1766) | ||
| #if defined(__NVCC__) && (__CUDACC_VER_MAJOR__ == 12 && __CUDACC_VER_MINOR__ >= 1 && __CUDACC_VER_MINOR__ <= 4) | ||
| // enables workaround for CTAD/constexpr issues in CUDA 12.1, 12.2, 12.3, 12.4 | ||
| // (https://github.com/GridTools/gridtools/issues/1766) | ||
| #define GT_NVCC_WORKAROUND_1766 1 |
There was a problem hiding this comment.
parts of this workaround are not needed in cuda 12.4, but then there are more issues that were not in cuda 12.3
|
In general CUDA 12.4 should be skipped if possible. The basic workarounds are enabled, but not all problems are fixed/can be fixed in the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.