Feature/wsieg1 #184
Merged
Feature/wsieg1 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhyshr
force-pushed
the
feature/wsieg1
branch
from
d539e95 to
c2c121a
Compare
abhyshr
approved these changes
Jan 23, 2024
| @@ -6,6 +6,9 @@ | |||
| // ----------------------------------------------------------- | |||
| /** | |||
| * @file wsieg1.cpp | |||
| * @author Shuangshuang Jin | |||
There was a problem hiding this comment.
Remove the author and date, we will not be adding individual authors in the code.
| @@ -30,7 +33,8 @@ gridpack::dynamic_simulation::Wsieg1Model::Wsieg1Model(void) | |||
| SecondGenExists = false; | |||
| OptionToModifyLimitsForInitialStateLimitViolation = true; | |||
| w = 0.0; | |||
| dx1LL = 0; | |||
| printf("---yuan debug constructor---\n"); | |||
There was a problem hiding this comment.
Please remove printf statement
| @@ -41,7 +45,7 @@ gridpack::dynamic_simulation::Wsieg1Model::Wsieg1Model(void) | |||
| dx3Turb1_1 = 0; | |||
| dx4Turb2_1 = 0; | |||
| dx5Turb3_1 = 0; | |||
| dx6Turb4_1 = 0; | |||
| dx6Turb4_1 = 0;*/ | |||
There was a problem hiding this comment.
Please remove this commented out cod AND any future instances of commented out code.
| if (!data->getValue(GOVERNOR_IBLOCK, &Iblock, idx)) Iblock = 0.0; // Iblock | ||
|
|
||
| int debug_print_params=1; | ||
| if (debug_print_params) { |
There was a problem hiding this comment.
What is debug_print_parama? Where does it come from? Please remove all this printing.
| } else | ||
| u5 = 0; | ||
| //-- yuan comment and add below -// | ||
| // u4 = NGV_blk.init_given_y(u5); // Implemented a .int_given_y method for PiecewiseSlope in dblock |
There was a problem hiding this comment.
Please remove any commented out code and remove any personalized comments such as "yuan ---"
| u1 = Leadlag_blk.init_given_y(0.0); | ||
| //-- yuan comment and add above -// | ||
|
|
||
| //-- yuan comment below -// |
There was a problem hiding this comment.
Any commented out code should be removed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of the updates for the wsieg1 model using control blocks