Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic os.Args[1] #190

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

tisonkun
Copy link
Contributor

So that gtctl without args prints help.

@tisonkun tisonkun requested a review from zyy17 February 20, 2024 17:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (117cbfb) 37.76% compared to head (18dca15) 37.76%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #190   +/-   ##
========================================
  Coverage    37.76%   37.76%           
========================================
  Files           16       16           
  Lines         1300     1300           
========================================
  Hits           491      491           
  Misses         704      704           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 7fb3796 into GreptimeTeam:develop Feb 21, 2024
6 checks passed
@tisonkun tisonkun deleted the fix-panic branch February 21, 2024 07:11
MichaelScofield pushed a commit to MichaelScofield/gtctl that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants