feat: support to accept values file #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
+ Coverage 35.36% 36.01% +0.64%
===========================================
Files 11 12 +1
Lines 1377 1430 +53
===========================================
+ Hits 487 515 +28
- Misses 793 812 +19
- Partials 97 103 +6
☔ View full report in Codecov by Sentry. |
Signed-off-by: zyy17 <[email protected]>
Signed-off-by: zyy17 <[email protected]>
1. Rename helm.Manager to helm.Loader; 2. Add 'pkg/helm/values*" to make values operation more flexiable; 3. Update unit test cases; Signed-off-by: zyy17 <[email protected]>
Signed-off-by: zyy17 <[email protected]>
zyy17
force-pushed
the
feat/support-values-file
branch
from
b732e39 to
d2d64c0
Compare
shawnh2
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #134.